feat: Add id prop to Text, TouchableWithoutFeedback and View components

[gabrieldonadel]

Summary

This adds the id prop to Text, TouchableWithoutFeedback and View components as requested on #34424 mapping the existing nativeID prop to id. As this components are inherited by others this also adds the id prop support to Image, TouchableBounce, TouchableHighlight, TouchableOpacity and TextInput.
This PR also adds android tests ensuring that the id property is passed to the native view via the nativeID prop, these tests were based on the existing nativeID tests (NativeIdTestCase.java).

Changelog

[General] [Added] - Add id prop to Text, TouchableWithoutFeedback and View components

Test Plan

Ensure that the new id prop android tests pass on CircleCI

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,641,920	-7
android	hermes	armeabi-v7a	7,054,280	+0
android	hermes	x86	7,943,689	-5
android	hermes	x86_64	7,915,598	-7
android	jsc	arm64-v8a	9,515,616	+75
android	jsc	armeabi-v7a	8,291,238	+85
android	jsc	x86	9,454,950	+80
android	jsc	x86_64	10,046,016	+79

Base commit: e8739e9
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 73abcba
Branch: main

[facebook-github-bot]

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[lunaleaps]

@gabrieldonadel Wow you're on fire with all these PRs! 👏
Can we also add a PR for documentation for this new property and also a PR for https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-native? We probably won't be able to merge (since this would target 0.71 and DT doesn't have a package for main) -- but we have plans to move those types into this repo and it would help me track the change. Let me know if you need help with that!

[gabrieldonadel]

@gabrieldonadel Wow you're on fire with all these PRs! 👏 Can we also add a PR for documentation for this new property and also a PR for https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-native? We probably won't be able to merge (since this would target 0.71 and DT doesn't have a package for main) -- but we have plans to move those types into this repo and it would help me track the change. Let me know if you need help with that!

Hi @lunaleaps, thanks for the kind words. I've just pushed a PR updating the docs (facebook/react-native-website#3285) and another one for DefinitelyTyped (DefinitelyTyped/DefinitelyTyped#62019)

[facebook-github-bot]

@necolas has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[cipolleschi]

Hi @gabrieldonadel, thanks for this PR. However, I don't think that if we are already using an optional property (id?) it should also have an optional type ?string.

Also, this definition conflicts with some other internal definition we have where the prop is defined as

id?: string

Could you update the PR so I can try to reimport it and merge it?

[gabrieldonadel]

Sure, I've just updated it

[necolas]

The internal failure was because a component was defining id for custom purposes and didn't strip it from the props it forwarded to the RN components. We should check what the type is in React DOM, and patch the internal RN code if this type should be an optional string...although I don't understand why Flow would complain about receiving a string for an optional string value.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @gabrieldonadel in 3e97d5f.

^{When will my fix make it into a release? | Upcoming Releases}