Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix id prop not working on all Touchable components #38169

Closed

Conversation

gabrieldonadel
Copy link
Collaborator

Summary:

This PR fixed the id prop to being correctly mapped to nativeID on the following components: TouchableBounce, TouchableHighlight, TouchableNativeFeedback, and TouchableOpacity.

Closes #38117
Follow up of #34522

Changelog:

[GENERAL] [FIXED] - Fix id prop not working on TouchableBounce, TouchableHighlight, TouchableNativeFeedback, and TouchableOpacity

Test Plan:

Ensure that the id prop android tests pass on CircleCI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Expo Partner: Expo Partner labels Jul 4, 2023
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,060,782 +12
android hermes armeabi-v7a 8,310,108 +10
android hermes x86 9,576,989 +9
android hermes x86_64 9,419,419 +17
android jsc arm64-v8a 9,613,528 +43
android jsc armeabi-v7a 8,740,147 +29
android jsc x86 9,700,468 +39
android jsc x86_64 9,947,028 +30

Base commit: e64373a
Branch: main

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

This pull request was successfully merged by @gabrieldonadel in 0e80fdb.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Jul 4, 2023
@gabrieldonadel gabrieldonadel deleted the feat/add-id-to-touchables branch July 4, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Expo Partner: Expo Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Id not working on Touchable*
3 participants