Fix Hermes not being downloaded on RC5 #33945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With RC5, we're not effectively downloading the Hermes tarball from the Github releases. Here the fix.
Changelog
[Internal] - Fix Hermes not being downloaded on RC5 on iOS
Test Plan
This PR should be merged on the release branch alongside this cherry-pick:
f1775ba
How I tested this.
npx react-native init RN069 --version next --skip-installecho "hermes-2022-05-20-RNv0.69.0-ee8941b8874132b8f83e4486b63ed5c19fc3f111" > node_modules/react-native/sdks/.hermesversionreact_native_pods.rbfile.node_modules/react-native/sdks/hermes-engine/hermes-engine.podspecif version == '1000.0.0' Pod::UI.puts '[Hermes] Hermes needs to be compiled, installing hermes-engine may take a while...'.yellow if Object.const_defined?("Pod::UI") source[:git] = git source[:commit] = `git ls-remote https://github.com/facebook/hermes main | cut -f 1`.strip elsif currentremote.strip.end_with?("facebook/react-native.git") and currentbranch.strip.end_with?("-stable") Pod::UI.puts '[Hermes] Detected that you are on a React Native release branch, building Hermes from source...'.yellow if Object.const_defined?("Pod::UI") source[:git] = git source[:commit] = `git ls-remote https://github.com/facebook/hermes main | cut -f 1`.strip else + source[:http] = "https://github.com/cortinico/react-native/releases/download/v#{version}/hermes-runtime-darwin-v#{version}.tar.gz" - source[:http] = "https://github.com/facebook/react-native/releases/download/v#{version}/hermes-runtime-darwin-v#{version}.tar.gz" endpod installnpx react-native run-ios