Skip to content

Commit d5e0659

Browse files
cortinicofacebook-github-bot
authored andcommitted
Backport Changes needed to let Hermes actually download the compiled tarball.
Summary: I'm backporting PR #33945 to main as it was merged on the release branch to unblock 0.69. Those changes are necessary as Hermes was not being donwloaded at all during `pod install` on .69 and the app was failing to build with a missing `hermes/hermes.h` import. Changelog: [iOS] [Fixed] - Fix Hermes not being properly downloaded during pod install Reviewed By: hramos Differential Revision: D36810787 fbshipit-source-id: f898e61b6536dfcfc81feeff740703fbd697b000
1 parent 0262b49 commit d5e0659

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -989,7 +989,7 @@ jobs:
989989
mkdir -p /tmp/cocoapods-package-root/destroot
990990
mkdir -p /tmp/hermes/output
991991
cp -R ./destroot /tmp/cocoapods-package-root
992-
cp hermes-engine.podspec LICENSE /tmp/cocoapods-package-root
992+
cp LICENSE /tmp/cocoapods-package-root
993993
994994
tar -C /tmp/cocoapods-package-root/ -czvf /tmp/hermes/output/hermes-runtime-darwin-v$(get_release_version).tar.gz .
995995
- save_cache:

scripts/react_native_pods.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def use_react_native! (options={})
114114

115115
pod 'React-hermes', :path => "#{prefix}/ReactCommon/hermes"
116116
pod 'libevent', '~> 2.1.12'
117-
pod 'hermes-engine', :path => "#{prefix}/sdks/hermes/hermes-engine.podspec"
117+
pod 'hermes-engine', :podspec => "#{prefix}/sdks/hermes/hermes-engine.podspec"
118118
end
119119

120120
# CocoaPods `configurations` option ensures that the target is copied only for the specified configurations,

0 commit comments

Comments
 (0)