Skip to content

Remove with_brew_cache_span from Circle's config #33831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

f-meloni
Copy link
Contributor

@f-meloni f-meloni commented May 13, 2022

Summary

The machines have on their env HOMEBREW_NO_AUTO_UPDATE=1, hence I believe that with_brew_cache_span is not needed anymore.

If this works it should save the cache downloading and unarchiving time

Changelog

[Internal] - Remove with_brew_cache_span from Circle's config

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 13, 2022
@f-meloni
Copy link
Contributor Author

f-meloni commented May 13, 2022

Those are the times of the steps before and after the changes

Before After
Screenshot 2022-05-13 at 12 55 45 Screenshot 2022-05-13 at 12 55 51
Screenshot 2022-05-13 at 12 56 15 Screenshot 2022-05-13 at 13 15 47
Screenshot 2022-05-13 at 13 20 08 Screenshot 2022-05-13 at 13 10 24

The only restore that takes more than before is the third one (test_ios), but the additional time it takes is still less than the time to get the cache

@facebook-github-bot
Copy link
Contributor

@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented May 13, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,789,543 +0
android hermes armeabi-v7a 7,193,179 +0
android hermes x86 8,099,369 +0
android hermes x86_64 8,078,462 +0
android jsc arm64-v8a 9,662,151 +0
android jsc armeabi-v7a 8,434,564 +0
android jsc x86 9,612,577 +0
android jsc x86_64 10,208,856 +0

Base commit: 0c7543d
Branch: main

@f-meloni f-meloni marked this pull request as ready for review May 13, 2022 13:59
@f-meloni f-meloni requested a review from hramos as a code owner May 13, 2022 13:59
@analysis-bot
Copy link

analysis-bot commented May 13, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 99e7373
Branch: main

@facebook-github-bot
Copy link
Contributor

@f-meloni has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @f-meloni in e3a0eea.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 13, 2022
@yungsters yungsters deleted the remove_with_brew_cache_span branch August 12, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants