Skip to content

Commit e3a0eea

Browse files
f-melonifacebook-github-bot
authored andcommitted
Remove with_brew_cache_span from Circle's config (#33831)
Summary: The machines have on their env `HOMEBREW_NO_AUTO_UPDATE=1`, hence I believe that `with_brew_cache_span` is not needed anymore. If this works it should save the cache downloading and unarchiving time ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] - Remove with_brew_cache_span from Circle's config Pull Request resolved: #33831 Reviewed By: cortinico Differential Revision: D36374646 Pulled By: f-meloni fbshipit-source-id: 0e6a35bb2c2dfe44e340e95a1b5e158389a3dfe9
1 parent 75fb346 commit e3a0eea

File tree

1 file changed

+9
-33
lines changed

1 file changed

+9
-33
lines changed

.circleci/config.yml

Lines changed: 9 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ references:
3636
# Anchors for the cache keys
3737

3838
cache_keys:
39-
brew_cache_key: &brew_cache_key v4-brew
4039
buck_cache_key: &buck_cache_key v3-buck-v2019.01.10.01-{{ checksum "scripts/circleci/buck_fetch.sh" }}}
4140
gems_cache_key: &gems_cache_key v1-gems-{{ checksum "Gemfile.lock" }}
4241
gradle_cache_key: &gradle_cache_key v1-gradle-{{ checksum "gradle/wrapper/gradle-wrapper.properties" }}-{{ checksum "ReactAndroid/gradle.properties" }}
@@ -183,21 +182,6 @@ commands:
183182
name: "Brew: Install << parameters.package >>"
184183
command: brew install << parameters.package >> >/dev/null
185184

186-
with_brew_cache_span:
187-
parameters:
188-
steps:
189-
type: steps
190-
steps:
191-
- restore_cache:
192-
keys:
193-
- *brew_cache_key
194-
- steps: << parameters.steps >>
195-
- save_cache:
196-
paths:
197-
- /usr/local/Homebrew
198-
- ~/Library/Caches/Homebrew
199-
key: *brew_cache_key
200-
201185
with_rntester_pods_cache_span:
202186
parameters:
203187
steps:
@@ -435,10 +419,8 @@ jobs:
435419
name: Set BUILD_HERMES_SOURCE=1
436420
command: echo "export BUILD_HERMES_SOURCE=1" >> $BASH_ENV
437421

438-
- with_brew_cache_span:
439-
steps:
440-
- brew_install:
441-
package: cmake
422+
- brew_install:
423+
package: cmake
442424

443425
- run:
444426
name: Setup the CocoaPods environment
@@ -492,15 +474,11 @@ jobs:
492474
echo 'export PATH=/usr/local/opt/node@16/bin:$PATH' >> $BASH_ENV
493475
source $BASH_ENV
494476
495-
- with_brew_cache_span:
496-
steps:
497-
- brew_install:
498-
package: watchman cmake
499-
- run:
500-
name: "Brew: Tap wix/brew"
501-
command: brew tap wix/brew >/dev/null
502-
- brew_install:
503-
package: applesimutils
477+
- run:
478+
name: "Brew: Tap wix/brew"
479+
command: brew tap wix/brew >/dev/null
480+
- brew_install:
481+
package: applesimutils watchman cmake
504482

505483
- run:
506484
name: Configure Watchman
@@ -771,10 +749,8 @@ jobs:
771749
name: Set BUILD_HERMES_SOURCE=1
772750
command: echo "export BUILD_HERMES_SOURCE=1" >> $BASH_ENV
773751

774-
- with_brew_cache_span:
775-
steps:
776-
- brew_install:
777-
package: cmake
752+
- brew_install:
753+
package: cmake
778754

779755
- run:
780756
name: Install CocoaPods dependencies

0 commit comments

Comments
 (0)