Fixed android MissingWebviewPackage exception as the current logic is flawed.

[KunalFarmah98]

Summary

The check implemented in PR #29089 is flawed as the exception class name and message depends on the OS version as well as the OEM. In OxygenOS running android 11, it comes out as RuntimeException and the check fails and hence the crash occurs again.
There is a simple fix to that as well, by checking the message instead of the exception class.
Here is the snippet:

 private @Nullable CookieManager getCookieManager() {
    if (mCookieManager == null) {
      possiblyWorkaroundSyncManager(mContext);
      try {
        mCookieManager = CookieManager.getInstance();
      } catch (IllegalArgumentException ex) {
        // https://bugs.chromium.org/p/chromium/issues/detail?id=559720
        return null;
      } catch (Exception exception) {
        String message = exception.getMessage();
        // We cannot catch MissingWebViewPackageException as it is in a private / system API
        // class. This validates the exception's message to ensure we are only handling this
        // specific exception.
        // The exception class doesn't always contain the correct name as it depends on the OEM
        // and OS version. It is better to check the message for clues regarding the exception
        // as that is somewhat consistent across OEMs.
        // https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/webkit/WebViewFactory.java#348
      if (message!=null && 
              (message.contains("WebView provider") 
                || message.contains("No WebView installed")
                  || message.contains("WebView"))) {
          return null;
        } else {
          throw exception;
        }
      }
    }

Changelog

[General] [Added] - A fail proof check to catch any crash involving webview:
if (message!=null && (message.contains("WebView provider") || message.contains("No WebView installed") || message.contains("WebView")))
[General] [Removed] - Flawed check to catch WebViewProvider crash:
if (message != null && exception.getClass().getCanonicalName().contains("MissingWebViewPackageException"))

Test Plan

This code has been tested rigorously on OnePlus Nord CE 5G (Oxygen OS 11.0) and Realme X (Realme UI 2.0) both running on Android 11 and reproducing the crash on a hybrid (Native android + ReactNative) app that showed this crash in production being dependent on WebViews. I have implemented an entire patched fork of 0.67.2 to fix this issue in the app.

How to test:

1. Launch any app that has a webview.
2. Go to settings->apps->Android System Webview -> disable.
3. Resume the app.
4. Open a webview and notice that the app will not crash.

In current version:
App crashes on startup as the exception escapes the catch block.
If it survives startup (did on Realme X), it will crash once you try to open a webview.

[facebook-github-bot]

Hi @KunalFarmah98!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[pull-bot]

	Warnings
⚠️	❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS against bb8b211

[pull-bot]

PR build artifact for a47f2fc is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,719,123	-584,122
android	hermes	armeabi-v7a	7,246,798	-393,931
android	hermes	x86	8,138,539	-639,612
android	hermes	x86_64	8,103,849	-611,047
android	jsc	arm64-v8a	9,638,205	-149,398
android	jsc	armeabi-v7a	8,553,408	-219,049
android	jsc	x86	9,651,913	-101,776
android	jsc	x86_64	10,260,901	-88,832

Base commit: 4cbcb7a
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[pull-bot]

PR build artifact for bb8b211 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 4cbcb7a
Branch: main

[cortinico]

Hey @KunalFarmah98, thanks for your PR.
Is there a specific reason why you're targeting the 0.67-stable branch instead of main?