Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS CI: Store bundle size info for release branch as well #32418

Closed
wants to merge 1 commit into from
Closed

OSS CI: Store bundle size info for release branch as well #32418

wants to merge 1 commit into from

Conversation

fkgozali
Copy link
Contributor

Summary:
This commit does 2 things:

  • Process and store stats for *-stable branches, in addition to main
  • Print out the new stats to stdout, so that CI jobs can display them for verification purpose

This also means a new field branch is used for the Firestore data.

Changelog: [Internal]

Differential Revision: D31717251

@fkgozali fkgozali requested a review from hramos as a code owner October 16, 2021 23:08
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 16, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31717251

analysis-bot
analysis-bot suggested changes Oct 16, 2021
View reviewed changes
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues. Run yarn lint --fix to automatically fix problems.

bots/report-bundle-size.js
collection,
GITHUB_SHA,
validatedStats,
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace ·await·datastore.getLatestDocument(collection,·GITHUB_REF with ⏎········(await·datastore.getLatestDocument(collection,·GITHUB_REF)

bots/report-bundle-size.js
}),
'',
`Base commit: ${document.commit}`,
].join('\n');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier/prettier: Replace ·await·datastore.getLatestDocument(collection,·'main' with ⏎······(await·datastore.getLatestDocument(collection,·'main')

@pull-bot
Copy link

pull-bot commented Oct 16, 2021 •
edited
Loading

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against ed38289

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31717251

fkgozali added a commit to fkgozali/react-native that referenced this pull request Oct 16, 2021
@fkgozali @facebook-github-bot
OSS CI: Store bundle size info for release branch as well (facebook#3…
43e0453 
…2418)

Summary:
Pull Request resolved: facebook#32418

This commit does 2 things:
* Process and store stats for *-stable branches, in addition to main
* Print out the new stats to stdout, so that CI jobs can display them for verification purpose

This also means a new field `branch` is used for the Firestore data.

Changelog: [Internal]

Differential Revision: D31717251

fbshipit-source-id: d5a5e03c7937ae5209f3d2d33e1f9cc6631da913
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31717251

fkgozali added a commit to fkgozali/react-native that referenced this pull request Oct 16, 2021
@fkgozali @facebook-github-bot
OSS CI: Store bundle size info for release branch as well (facebook#3…
748b377 
…2418)

Summary:
Pull Request resolved: facebook#32418

This commit does 2 things:
* Process and store stats for *-stable branches, in addition to main
* Print out the new stats to stdout, so that CI jobs can display them for verification purpose

This also means a new field `branch` is used for the Firestore data.

Changelog: [Internal]

Differential Revision: D31717251

fbshipit-source-id: 2dc5df543ed6956f65c49600af25a22808871738
@pull-bot
Copy link

PR build artifact for 748b377 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,718,707 +0
android hermes armeabi-v7a 7,246,378 +0
android hermes x86 8,138,127 +0
android hermes x86_64 8,103,429 +0
android jsc arm64-v8a 9,637,679 +0
android jsc armeabi-v7a 8,552,880 +0
android jsc x86 9,651,387 +0
android jsc x86_64 10,260,380 +0

Base commit: e1b698c
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: e1b698c
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31717251

fkgozali added a commit to fkgozali/react-native that referenced this pull request Oct 17, 2021
@fkgozali @facebook-github-bot
OSS CI: Store bundle size info for release branch as well (facebook#3…
9deb97b 
…2418)

Summary:
Pull Request resolved: facebook#32418

This commit does 2 things:
* Process and store stats for *-stable branches, in addition to main
* Print out the new stats to stdout, so that CI jobs can display them for verification purpose

This also means a new field `branch` is used for the Firestore data.

Changelog: [Internal]

Differential Revision: D31717251

fbshipit-source-id: 7fb653ef21fcd110318ad306947b9abce7e931c5
@pull-bot
Copy link

PR build artifact for 9deb97b is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@fkgozali @facebook-github-bot
OSS CI: Store bundle size info for release branch as well (facebook#3…
ed38289 
…2418)

Summary:
Pull Request resolved: facebook#32418

This commit does 2 things:
* Process and store stats for *-stable branches, in addition to main
* Print out the new stats to stdout, so that CI jobs can display them for verification purpose

This also means a new field `branch` is used for the Firestore data.

Changelog: [Internal]

Differential Revision: D31717251

fbshipit-source-id: 86dc30c24d00238449546c3987e9e3ed0b081ffe
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D31717251

@pull-bot
Copy link

PR build artifact for ed38289 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 0c07500.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 18, 2021
fkgozali added a commit that referenced this pull request Oct 19, 2021
@fkgozali
OSS CI: Store bundle size info for release branch as well (#32418)
0073171 
Summary:
Pull Request resolved: #32418

This commit does 2 things:
* Process and store stats for *-stable branches, in addition to main
* Print out the new stats to stdout, so that CI jobs can display them for verification purpose

This also means a new field `branch` is used for the Firestore data.

Changelog: [Internal]

Reviewed By: hramos

Differential Revision: D31717251

fbshipit-source-id: 9dbfa8fb8f0243c013dcd822230400d26c09eaa4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@analysis-bot analysis-bot analysis-bot requested changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fkgozali @facebook-github-bot @pull-bot @analysis-bot