fix: remove deprecated event listener method from appearance.js

[matinzd]

Summary

Remove unused deprecated event listener method from appearance.js

Changelog

[General] [Removed] - Remove deprecated removeListener from Appearance that causes deprecation message in log box.

Test Plan

[pull-bot]

PR build artifact for 51b7446 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	9,351,144	+51
android	hermes	armeabi-v7a	8,333,208	+63
android	hermes	x86	9,983,535	+66
android	hermes	x86_64	9,768,895	+52
android	jsc	arm64-v8a	10,665,521	-9
android	jsc	armeabi-v7a	9,311,065	-6
android	jsc	x86	10,777,585	-12
android	jsc	x86_64	11,216,892	-4

Base commit: b25d9e4
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 8adedfe
Branch: main

[yungsters]

Thanks for the contribution, @matinzd. I have added this to my list and will take a look as soon as possible.

[matinzd]

Thanks for the contribution, @matinzd. I have added this to my list and will take a look as soon as possible.

Thank you! Let me know.

[yungsters]

Thanks again for the contribution, @matinzd.

Can you run prettier on this change? It is failing the test_js CI jobs as-is.

Also, would you be interested in removing the other deprecated remove listener methods? 😁

[matinzd]

Thanks again for the contribution, @matinzd.

Can you run prettier on this change? It is failing the test_js CI jobs as-is.

Also, would you be interested in removing the other deprecated remove listener methods? 😁

Of course, I will do it in another PR. Branch rebased with main and CI should pass.

[yungsters]

One more small thing — the changelog entry should be [Removed] for removing the deprecated method.

[matinzd]

One more small thing — the changelog entry should be [Removed] for removing the deprecated method.

Changed. Is it ok?

[yungsters]

Since it is affects a public interface, it shouldn't have the [Removed] [Internal].

Otherwise, it looks great! I'll be able to import once that is corrected. Thank you.

[matinzd]

Since it is affects a public interface, it shouldn't have the [Removed].

Otherwise, it looks great! I'll be able to import once that is corrected. Thank you.

Sorry, as you mentioned above I changed Fix to Removed. What should I do now?

[yungsters]

This is what I meant:

- [Internal] [Removed] - Remove deprecated removeListener from Appearance that causes deprecation message in log box.
+ [Removed] - Remove deprecated removeListener from Appearance that causes deprecation message in log box.

If you don't mind, I can make that change in the process of importing this diff.

[facebook-github-bot]

@yungsters has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[yungsters]

Sorry, I just realized why you were confused.

I made a typo in my comment. I meant to suggest removing "[Internal]", not "[Removed]".

Sorry for the confusion!

[pull-bot]

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 431fba0

[matinzd]

This is what I meant:

- [Internal] [Removed] - Remove deprecated removeListener from Appearance that causes deprecation message in log box.
+ [Removed] - Remove deprecated removeListener from Appearance that causes deprecation message in log box.

If you don't mind, I can make that change in the process of importing this diff.

The category should be there. I changed it to General. @yungsters

[matinzd]

Any updates? @yungsters

[facebook-github-bot]

@yungsters has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @matinzd in 8dfbed7.

^{When will my fix make it into a release? | Upcoming Releases}