fix: remove deprecated event listener method from appearance.js

facebook · Mar 31, 2022 · 1ba6ba2 · 1ba6ba2
1 parent 28064ee
commit 1ba6ba2
Show file tree

Hide file tree

Showing 182 changed files with 2,608 additions and 842 deletions.
diff --git a/BUCK b/BUCK
@@ -58,6 +58,7 @@ fb_native.genrule(
     ) + [
         react_native_root_target("packages/rn-tester:nativecomponent-srcs"),
     ],
+    labels = ["uses_hg"],
     cmd = "$(exe {}) $OUT $SRCS".format(react_native_root_target("packages/react-native-codegen:write_to_json")),
     out = "schema-rncore.json",
 )
@@ -97,6 +98,7 @@ rn_xplat_cxx_library2(
     # it's linked in your app, transparently use it".
     labels = [
         "depslint_never_remove",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode() + [
@@ -153,7 +155,10 @@ rn_xplat_cxx_library2(
     frameworks = [
         "$SDKROOT/System/Library/Frameworks/Foundation.framework",
     ],
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode() + ["-DWITH_FBSYSTRACE=1"],
     visibility = ["PUBLIC"],
     deps = [
@@ -190,7 +195,10 @@ rn_xplat_cxx_library2(
     frameworks = [
         "$SDKROOT/System/Library/Frameworks/Foundation.framework",
     ],
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(),
     visibility = ["PUBLIC"],
     deps = [
@@ -215,7 +223,10 @@ rn_xplat_cxx_library2(
     ),
     contacts = ["oncall+react_native@xmail.facebook.com"],
     fbobjc_enable_exceptions = True,
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(),
     visibility = ["PUBLIC"],
     deps = [
@@ -418,6 +429,7 @@ rn_xplat_cxx_library2(
     labels = [
         "depslint_never_add",
         "depslint_never_remove",  # Some old NativeModule still relies on +load unfortunately.
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     platform_preprocessor_flags = [(
@@ -508,6 +520,7 @@ rn_xplat_cxx_library2(
     header_path_prefix = "React",
     labels = [
         "disable_plugins_only_validation",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     plugins = [
@@ -590,7 +603,10 @@ rn_apple_library(
         "$PLATFORM_DIR/Developer/Library/Frameworks/Foundation.framework",
     ],
     inherited_buck_flags = get_static_library_ios_flags(),
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(),
     reexport_all_header_dependencies = True,
     deps = [
@@ -660,6 +676,7 @@ rn_apple_library(
     contacts = ["oncall+react_native@xmail.facebook.com"],
     labels = [
         "disable_plugins_only_validation",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     plugins = [react_fabric_component_plugin_provider("Image", "RCTImageCls")],
@@ -690,7 +707,10 @@ rn_xplat_cxx_library2(
     },
     compiler_flags = ["-Wall"],
     contacts = ["oncall+react_native@xmail.facebook.com"],
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     visibility = ["PUBLIC"],
     deps = [
         "//xplat/js/react-native-github:RCTImage",
@@ -719,7 +739,10 @@ rn_library(
             "Libraries/Components/Switch/SwitchSchema.js",
         ],
     ),
-    labels = ["supermodule:xplat/default/public.react_native.core"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+        "supermodule:xplat/default/public.react_native.core",
+    ],
     visibility = ["PUBLIC"],
     deps = [
         "//xplat/js:node_modules__abort_19controller",
@@ -756,7 +779,10 @@ rn_codegen(
     android_package_name = "com.facebook.fbreact.specs",
     codegen_modules = True,
     ios_assume_nonnull = False,
-    library_labels = ["supermodule:xplat/default/public.react_native.infra"],
+    library_labels = [
+        "supermodule:xplat/default/public.react_native.infra",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+    ],
     native_module_spec_name = "FBReactNativeSpec",
     src_prefix = "Libraries/",
 )
@@ -766,7 +792,10 @@ rn_codegen(
     name = "FBReactNativeComponentSpec",
     codegen_components = True,
     ios_assume_nonnull = False,
-    library_labels = ["supermodule:xplat/default/public.react_native.infra"],
+    library_labels = [
+        "supermodule:xplat/default/public.react_native.infra",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+    ],
     src_prefix = "Libraries/",
 )
 
@@ -800,6 +829,7 @@ rn_apple_library(
         "depslint_never_remove",  # Some old NativeModule still relies on +load unfortunately.
         "disable_plugins_only_validation",
         "extension_api_allow_unsafe_unavailable_usages",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     plugins =
@@ -849,6 +879,7 @@ rn_apple_library(
     labels = [
         "depslint_never_remove",  # Some old NativeModule still relies on +load unfortunately.
         "disable_plugins_only_validation",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     plugins =
@@ -907,6 +938,7 @@ rn_apple_library(
         "depslint_never_remove",  # Some old NativeModule still relies on +load unfortunately.
         "disable_plugins_only_validation",
         "extension_api_allow_unsafe_unavailable_usages",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     plugins =
@@ -954,6 +986,7 @@ rn_apple_library(
         "depslint_never_remove",  # Some old NativeModule still relies on +load unfortunately.
         "disable_plugins_only_validation",
         "extension_api_allow_unsafe_unavailable_usages",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     plugins =
@@ -1005,6 +1038,7 @@ rn_apple_library(
         "depslint_never_remove",  # Some old NativeModule still relies on +load unfortunately.
         "disable_plugins_only_validation",
         "extension_api_allow_unsafe_unavailable_usages",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     plugins =
@@ -1085,6 +1119,7 @@ rn_apple_library(
         "depslint_never_remove",  # Some old NativeModule still relies on +load unfortunately.
         "disable_plugins_only_validation",
         "extension_api_allow_unsafe_unavailable_usages",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     plugins =
@@ -1218,6 +1253,7 @@ rn_xplat_cxx_library2(
     ],
     labels = [
         "depslint_never_remove",  # Some old NativeModule still relies on +load unfortunately.
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(),
@@ -1250,6 +1286,7 @@ rn_apple_library(
     labels = [
         "depslint_never_remove",
         "disable_plugins_only_validation",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     plugins = react_module_plugin_providers(
@@ -1290,6 +1327,7 @@ rn_xplat_cxx_library2(
     ],
     labels = [
         "depslint_never_remove",  # Some old NativeModule still relies on +load unfortunately.
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(),
@@ -1322,6 +1360,7 @@ rn_xplat_cxx_library2(
     ],
     labels = [
         "depslint_never_remove",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(),
@@ -1356,6 +1395,7 @@ rn_xplat_cxx_library2(
     ],
     labels = [
         "depslint_never_remove",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(),
@@ -1391,6 +1431,7 @@ rn_xplat_cxx_library2(
     ],
     labels = [
         "depslint_never_remove",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     preprocessor_flags = get_objc_arc_preprocessor_flags() + get_preprocessor_flags_for_build_mode(),
@@ -1412,6 +1453,7 @@ rn_xplat_cxx_library2(
         "React/RCTConvert+CoreLocation.h": RCTVIEWS_PATH + "RCTConvert+CoreLocation.h",
     },
     labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     visibility = [

diff --git a/IntegrationTests/BUCK b/IntegrationTests/BUCK
@@ -17,7 +17,10 @@ rn_library(
             "websocket_integration_test_server.js",
         ],
     ),
-    labels = ["supermodule:xplat/default/public.react_native.tests"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+        "supermodule:xplat/default/public.react_native.tests",
+    ],
     skip_processors = True,
     visibility = ["PUBLIC"],
     deps = [

diff --git a/Libraries/Components/View/ViewPropTypes.js b/Libraries/Components/View/ViewPropTypes.js
@@ -99,6 +99,20 @@ type TouchEventProps = $ReadOnly<{|
   onTouchStartCapture?: ?(e: PressEvent) => void,
 |}>;
 
+type PointerEventCallbackProps = $ReadOnly<{|
+  onPointerCancel?: ?(e: PointerEvent) => void,
+  onPointerCancelCapture?: ?(e: PointerEvent) => void,
+  onPointerDown?: ?(e: PointerEvent) => void,
+  onPointerDownCapture?: ?(e: PointerEvent) => void,
+  onPointerEnter2?: ?(e: PointerEvent) => void,
+  onPointerLeave2?: ?(e: PointerEvent) => void,
+  onPointerEnter2Capture?: ?(e: PointerEvent) => void,
+  onPointerLeave2Capture?: ?(e: PointerEvent) => void,
+  onPointerMove2Capture?: ?(e: PointerEvent) => void,
+  onPointerUp?: ?(e: PointerEvent) => void,
+  onPointerUpCapture?: ?(e: PointerEvent) => void,
+|}>;
+
 /**
  * For most touch interactions, you'll simply want to wrap your component in
  * `TouchableHighlight` or `TouchableOpacity`. Check out `Touchable.js`,
@@ -382,6 +396,7 @@ export type ViewProps = $ReadOnly<{|
   ...GestureResponderEventProps,
   ...MouseEventProps,
   ...TouchEventProps,
+  ...PointerEventCallbackProps,
   ...AndroidViewProps,
   ...IOSViewProps,
 

diff --git a/Libraries/FBLazyVector/BUCK b/Libraries/FBLazyVector/BUCK
@@ -12,7 +12,10 @@ fb_apple_library(
     enable_exceptions = False,
     extension_api_only = True,
     frameworks = [],
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     link_whole = False,
     visibility = ["PUBLIC"],
 )
diff --git a/Libraries/NativeComponent/PlatformBaseViewConfig.js b/Libraries/NativeComponent/PlatformBaseViewConfig.js
@@ -132,6 +132,44 @@ const PlatformBaseViewConfig: PartialViewConfigWithoutName =
               bubbled: 'onTouchMove',
             },
           },
+          topPointerCancel: {
+            phasedRegistrationNames: {
+              captured: 'onPointerCancelCapture',
+              bubbled: 'onPointerCancel',
+            },
+          },
+          topPointerDown: {
+            phasedRegistrationNames: {
+              captured: 'onPointerDownCapture',
+              bubbled: 'onPointerDown',
+            },
+          },
+          topPointerEnter2: {
+            phasedRegistrationNames: {
+              captured: 'onPointerEnter2Capture',
+              bubbled: 'onPointerEnter2',
+              skipBubbling: true,
+            },
+          },
+          topPointerLeave2: {
+            phasedRegistrationNames: {
+              captured: 'onPointerLeave2Capture',
+              bubbled: 'onPointerLeave2',
+              skipBubbling: true,
+            },
+          },
+          topPointerMove2: {
+            phasedRegistrationNames: {
+              captured: 'onPointerMove2Capture',
+              bubbled: 'onPointerMove2',
+            },
+          },
+          topPointerUp: {
+            phasedRegistrationNames: {
+              captured: 'onPointerUpCapture',
+              bubbled: 'onPointerUp',
+            },
+          },
         },
         validAttributes: {
           // @ReactProps from BaseViewManager

diff --git a/Libraries/RCTRequired/BUCK b/Libraries/RCTRequired/BUCK
@@ -10,5 +10,8 @@ fb_apple_library(
     contacts = ["oncall+react_native@xmail.facebook.com"],
     extension_api_only = True,
     frameworks = ["Foundation"],
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
 )
diff --git a/Libraries/Types/CoreEventTypes.js b/Libraries/Types/CoreEventTypes.js
@@ -83,6 +83,18 @@ export type TextLayoutEvent = SyntheticEvent<
   |}>,
 >;
 
+export type PointerEvent = ResponderSyntheticEvent<
+  $ReadOnly<{|
+    pointerId: number,
+    pressure: number,
+    pointerType: string,
+    clientX: number,
+    clientY: number,
+    target: ?number,
+    timestamp: number,
+  |}>,
+>;
+
 export type PressEvent = ResponderSyntheticEvent<
   $ReadOnly<{|
     changedTouches: $ReadOnlyArray<$PropertyType<PressEvent, 'nativeEvent'>>,

diff --git a/Libraries/Utilities/Appearance.js b/Libraries/Utilities/Appearance.js
@@ -91,12 +91,4 @@ module.exports = {
   addChangeListener(listener: AppearanceListener): EventSubscription {
     return eventEmitter.addListener('change', listener);
   },
-
-  /**
-   * @deprecated Use `remove` on the EventSubscription from `addEventListener`.
-   */
-  removeChangeListener(listener: AppearanceListener): void {
-    // NOTE: This will report a deprecation notice via `console.error`.
-    eventEmitter.removeListener('change', listener);
-  },
 };
diff --git a/React/CoreModules/BUCK b/React/CoreModules/BUCK
@@ -38,6 +38,7 @@ rn_apple_library(
     labels = [
         "depslint_never_remove",  # Some old NativeModule still relies on +load unfortunately.
         "disable_plugins_only_validation",
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
         "supermodule:xplat/default/public.react_native.infra",
     ],
     link_whole = True,

diff --git a/ReactAndroid/src/androidTest/java/com/facebook/react/testing/network/BUCK b/ReactAndroid/src/androidTest/java/com/facebook/react/testing/network/BUCK
@@ -4,7 +4,10 @@ rn_android_library(
     name = "network",
     srcs = glob(["**/*.java"]),
     autoglob = False,
-    labels = ["supermodule:xplat/default/public.react_native.infra"],
+    labels = [
+        "pfh:ReactNative_CommonInfrastructurePlaceholde",
+        "supermodule:xplat/default/public.react_native.infra",
+    ],
     visibility = [
         "PUBLIC",
     ],