-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed alignItems: baseline
for <Text> elements on Android
#31575
Conversation
Base commit: 118489f |
@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Btw, I just realized that this feature is not implemented in Fabric (my bad!). I fixed it locally now and it will be a PR after/if this one is merged. |
Thanks! The only thing blocking me from landing this was finding time to test on Fabric, haha. So yeah, I definitely welcome a Fabric PR! And then I can import and get both reviewed and merged. |
Okie-dokie, #31639 does that for Fabric. Ideally it should be a three-diff stack but... you know, git hub. :( |
Thanks! I understand… 😞 I’ve imported both PRs already. Will do some extra testing and get them reviewed this week before I merge them. |
any news here? |
We've had some folks on leave and vacation the past few weeks, but I finally got internal reviews completed. I'll need to do some additional testing before I merge these, but I should be able to get to those this week. |
@yungsters merged this pull request in 1acf334. |
Summary
This fixes #20666 and #21918.
This is pretty much the same as 51b3529 but implemented for Android.
Now exposes the actual base-line offset value that allows Yoga to position it properly when
alignItems: baseline
is requested.Changelog
[Android][Fixed] - Fixed
alignItems: baseline
for elements on AndroidTest Plan
The same test case that we have for iOS.
Before:
After: