-
Notifications
You must be signed in to change notification settings - Fork 24.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed
alignItems: baseline
for <Text> elements on Android (#31575)
Summary: This fixes #20666 and #21918. This is pretty much the same as 51b3529 but implemented for Android. Now <Text> exposes the actual base-line offset value that allows Yoga to position it properly when `alignItems: baseline` is requested. ## Changelog [Android][Fixed] - Fixed `alignItems: baseline` for <Text> elements on Android Pull Request resolved: #31575 Test Plan: The same test case that we have for iOS. Before: <img width="487" alt="Screen Shot 2021-05-22 at 7 03 18 PM" src="https://user-images.githubusercontent.com/22032/119277516-d62b5100-bbe5-11eb-9141-3abe56e1a476.png"> After: <img width="487" alt="Screen Shot 2021-05-22 at 7 01 51 PM" src="https://user-images.githubusercontent.com/22032/119277518-d75c7e00-bbe5-11eb-9139-4c6b5fcd9157.png"> Reviewed By: JoshuaGross Differential Revision: D28631468 Pulled By: yungsters fbshipit-source-id: 7c259e469d19d8344298319f066b8437dfdedad0
- Loading branch information
1 parent
5d6484e
commit 1acf334
Showing
2 changed files
with
78 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters