Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hermesFlagsRelease not working with multiple productFlavors #31040

Closed
wants to merge 4 commits into from
Closed

Fix hermesFlagsRelease not working with multiple productFlavors #31040

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ed7edf
Fix hermesFlagsRelease not working with multiple productFlavors
geraintwhite Feb 23, 2021
3ce3b87
Merge branch 'master' into patch-3
geraintwhite Mar 19, 2021
736a226
Merge branch 'master' into patch-3
geraintwhite Mar 29, 2021
7b0d307
Merge branch 'master' into patch-3
geraintwhite May 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions react.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ afterEvaluate {
def hermesFlags;
def hbcTempFile = file("${jsBundleFile}.hbc")
exec {
if (targetName.toLowerCase().contains("release")) {
if (!targetName.toLowerCase().contains("debug")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure changing this logic for everyone won’t break the build somewhere (assuming that some people may have custom debug-oriented buildTypes). Maybe the best solution would be to introduce a lambda similar to enableHermesForVariant or flag like we have with bundleIn$targetName, and configure this logic from outside.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that probably is a better solution

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grit96, were you going to make the change based on the suggestion?

// Can't use ?: since that will also substitute valid empty lists
hermesFlags = config.hermesFlagsRelease
if (hermesFlags == null) hermesFlags = ["-O", "-output-source-map"]
Expand Down Expand Up @@ -327,7 +327,7 @@ afterEvaluate {
// This should really be done by packaging all Hermes related libs into
// two separate HermesDebug and HermesRelease AARs, but until then we'll
// kludge it by deleting the .so files out of the /transforms/ directory.
def isRelease = targetName.toLowerCase().contains("release")
def isRelease = !targetName.toLowerCase().contains("debug")
def libDir = "$buildDir/intermediates/transforms/"
def vmSelectionAction = {
fileTree(libDir).matching {
Expand Down