Fix hermesFlagsRelease not working with multiple productFlavors #31040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: 438a4cf |
Base commit: 438a4cf |
ShikaSD
reviewed
Mar 1, 2021
| @@ -186,7 +186,7 @@ afterEvaluate { | |||
| def hermesFlags; | |||
| def hbcTempFile = file("${jsBundleFile}.hbc") | |||
| exec { | |||
| if (targetName.toLowerCase().contains("release")) { | |||
| if (!targetName.toLowerCase().contains("debug")) { | |||
There was a problem hiding this comment.
I am not sure changing this logic for everyone won’t break the build somewhere (assuming that some people may have custom debug-oriented buildTypes). Maybe the best solution would be to introduce a lambda similar to enableHermesForVariant or flag like we have with bundleIn$targetName, and configure this logic from outside.
There was a problem hiding this comment.
Yes that probably is a better solution
There was a problem hiding this comment.
@grit96, were you going to make the change based on the suggestion?
|
Hi! Closing this PR since the comment hasn't been addressed for a while. Please reopen and ping me if you are still up for working on this. Thanks for your time! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 13, 2021
Summary: Ref #25601 (comment). From #31040. The `hermesFlagsRelease` option only works with the release build type, but not with other build types. This PR allows hermes flags on a per variant basis to be specified using the `hermesFlagsForVariant` lambda. It also allows the hermes debugger cleanup to be run on a per variant basis using the `deleteDebugFilesForVariant` lambda. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - Fix hermesFlags not working with multiple variants Pull Request resolved: #32281 Test Plan: Set the following options in `android/app/build.gradle` and ensure warnings are hidden when running `./gradlew assembleRelease` and `./gradlew assembleLive`. ``` hermesFlagsForVariant: { def v -> v.name.toLowerCase().contains('release') || v.name.toLowerCase().contains('live') ? ['-w'] : [] }, deleteDebugFilesForVariant: { def v -> v.name.toLowerCase().contains('release') || v.name.toLowerCase().contains('live') }, ``` Reviewed By: cortinico Differential Revision: D31234241 Pulled By: ShikaSD fbshipit-source-id: 2cb3dd63adbcd023061076b5a3b262a87b470518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #25601 (comment).
Summary
The
hermesFlagsReleaseoption only works with the release build type, but not with other build types. This PR considers other build types as release and enableshermesFlagsReleaseto apply to any non-debug build type.Changelog
[Android] [Fixed] - Fix hermesFlagsRelease not working with multiple productFlavors
Test Plan
Set
hermesFlagsRelease: ["-w"]inandroid/app/build.gradleand ensure warnings are hidden when running./gradlew assembleReleaseand./gradlew assembleLive.