Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default for hermes es6 proxy enabled #30142

Closed
wants to merge 1 commit into from
Closed

Use default for hermes es6 proxy enabled #30142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/HermesExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class HermesExecutor extends JavaScriptExecutor {
super(
config == null
? initHybridDefaultConfig()
: initHybrid(config.heapSizeMB, config.es6Proxy));
: initHybrid(config.heapSizeMB));
}

@Override
Expand All @@ -50,5 +50,5 @@ public String getName() {

private static native HybridData initHybridDefaultConfig();

private static native HybridData initHybrid(long heapSizeMB, boolean es6Proxy);
private static native HybridData initHybrid(long heapSizeMB);
}
8 changes: 3 additions & 5 deletions ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/OnLoad.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ namespace facebook {
namespace react {

static ::hermes::vm::RuntimeConfig makeRuntimeConfig(
jlong heapSizeMB,
bool es6Proxy) {
jlong heapSizeMB) {
namespace vm = ::hermes::vm;
auto gcConfigBuilder =
vm::GCConfig::Builder()
Expand All @@ -40,7 +39,6 @@ static ::hermes::vm::RuntimeConfig makeRuntimeConfig(

return vm::RuntimeConfig::Builder()
.withGCConfig(gcConfigBuilder.build())
.withES6Proxy(es6Proxy)
.build();
}

Expand Down Expand Up @@ -70,9 +68,9 @@ class HermesExecutorHolder
}

static jni::local_ref<jhybriddata>
initHybrid(jni::alias_ref<jclass>, jlong heapSizeMB, bool es6Proxy) {
initHybrid(jni::alias_ref<jclass>, jlong heapSizeMB) {
JReactMarker::setLogPerfMarkerIfNeeded();
auto runtimeConfig = makeRuntimeConfig(heapSizeMB, es6Proxy);
auto runtimeConfig = makeRuntimeConfig(heapSizeMB);
return makeCxxInstance(std::make_unique<HermesExecutorFactory>(
installBindings, JSIExecutor::defaultTimeoutInvoker, runtimeConfig));
}
Expand Down
1 change: 0 additions & 1 deletion ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/RuntimeConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
/** Holds runtime configuration for a Hermes VM instance (master or snapshot). */
public final class RuntimeConfig {
public long heapSizeMB;
public boolean es6Proxy;

RuntimeConfig() {}

Expand Down