-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default for hermes es6 proxy enabled #30142
Conversation
cc @mhorowitz |
Base commit: 7ebb71a |
Base commit: 7ebb71a |
Why did you choose to remove the config option, instead of setting the option to true? |
I figured the the option will eventually be removed from hermes as I don't see why Proxy support would be disabled if it is stable. Setting it to true explicitly works too if you prefer. Edit: One case I can see where using the default value from hermes is better is if someone is using an older version where proxy is not considered stable and is not enabled by default (before 0.7.0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mhorowitz has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @janicduplessis in a28dd38. When will my fix make it into a release? | Upcoming Releases |
Summary
Proxy is now enabled by default in hermes 0.7 (https://github.com/facebook/hermes/releases/tag/v0.7.0). However we currently disable it because of the config we pass.
This removes the config so proxy is now enabled.
Changelog
[Android] [Changed] - Use default for hermes es6 proxy enabled
Test Plan
Tested that proxy is now enabled (typeof Proxy !== 'undefined') with hermes 0.7.