Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default for hermes es6 proxy enabled #30142

Closed
wants to merge 1 commit into from

Conversation

janicduplessis
Copy link
Contributor

Summary

Proxy is now enabled by default in hermes 0.7 (https://github.com/facebook/hermes/releases/tag/v0.7.0). However we currently disable it because of the config we pass.

This removes the config so proxy is now enabled.

Changelog

[Android] [Changed] - Use default for hermes es6 proxy enabled

Test Plan

Tested that proxy is now enabled (typeof Proxy !== 'undefined') with hermes 0.7.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Oct 9, 2020
@janicduplessis
Copy link
Contributor Author

cc @mhorowitz

@react-native-bot react-native-bot added the Platform: Android Android applications. label Oct 9, 2020
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 7ebb71a

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,385,801 0
android hermes armeabi-v7a 7,013,117 0
android hermes x86 7,828,013 0
android hermes x86_64 7,717,499 0
android jsc arm64-v8a 9,532,102 0
android jsc armeabi-v7a 9,147,130 0
android jsc x86 9,396,778 0
android jsc x86_64 9,978,488 0

Base commit: 7ebb71a

@mhorowitz
Copy link
Contributor

Why did you choose to remove the config option, instead of setting the option to true?

@janicduplessis
Copy link
Contributor Author

janicduplessis commented Oct 9, 2020

I figured the the option will eventually be removed from hermes as I don't see why Proxy support would be disabled if it is stable. Setting it to true explicitly works too if you prefer.

Edit: One case I can see where using the default value from hermes is better is if someone is using an older version where proxy is not considered stable and is not enabled by default (before 0.7.0).

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhorowitz has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @janicduplessis in a28dd38.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 23, 2020
@janicduplessis janicduplessis deleted the hermes-proxy branch October 23, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged. Platform: Android Android applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants