Make "react-native start" work on Windows

[BerndWessels]

This is necessary to run react-native start on Windows.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

[mkonicek]

Thanks for doing this!

This way we lose the REACT_PACKAGER_LOG on Mac OS and Linux, @martinbigio is it used for anything?

I think a safer way would be to check for OS and only do this on Windows.

nit: Please keep the indentation.

[mkonicek]

@BerndWessels I committed your change in a5463c4, thanks for the fix!

If you want you could make the newWindow branch work on Windows too: react-native run-android calls the function with newWindow set to true. On Mac and Linux this will open a new terminal Window and start the packager in it. On Windows it's currently a no-op so you have to run react-native start manually.

[yeso126]

When I run react-native start I get a watcher took too long to load error, any workaround?

[mkonicek]

@yeso126 What version of watchman are you using? Can you tweak the watcher timeout at the line where it throws the error? The file can be found in node_modules. What sometimes fixes this on Mac is simply running watchman --version.

[yeso126]

I'm trying to run react-native start on windows, watchman is not supported

[mkonicek]

Ah of course sorry. We're using sane to do file watching. Not sure what causes the watcher to time out on Windows. Can you try increasing the timeout in this file (under your node_modules/react-native)?

https://github.com/facebook/react-native/blob/master/packager/react-packager/src/FileWatcher/index.js#L17