[0.12] Things we should get in for the next release

[ide]

• Making sure Android works with 0.12. Currently it has been tested against 0.11. I'm not yet sure what works or doesn't work. This is the biggest item. cc @mkonicek
• Fixing an arm64 error: [iOS] Undefined symbols for architecture arm64: "_RCTSetLogFunction" #2685 cc @javache
• Get the tests green
• Node 4 support. package.json has been updated which is the most important part, but it would be nice to get the diffs covered in [Node 4] Prepare for Node 4 #2545 in. At any rate, after 0.12 ships everyone using it should install Node 4 or newer. No more io.js.
• Reloading sometimes crashes the app due to some race condition when deallocing CoreText objects: [Text][Crash] RCTText setTextStorage crashes #2001. Update: fixing this will take longer according to @tadeuzagallo (Fixed in master, we can ship with 0.13-rc)
• Android displays red box on sample project: [Android] TypeError: expected dynamic type 'string', but had type 'int64' #2983

heads up @brentvatne @vjeux

[matth3wga0]

Do support Xcode 6.2 on Mavericks.

[ide]

AFAIK there are no plans for that. If anything Xcode 7 will become a requirement (not 100% sure that will be the case and depends on Facebook's Xcode upgrade path, but users of projects like React Native tend towards cutting-edge technologies).

[brentvatne]

This list looks good to me 👍

edit: actually, we should get the bundling working for Android as described here as well: #2703 (comment)

[vjeux]

@ide we already have both xcode6 and xcode7 running in our infra :)

[ide]

@vjeux sweet. I have a PR out to move the tests to run on Travis CI's Xcode 7 machines.. I think it doesn't pass the tests yet but good to know that FB is on XC 7 now.

[ide]

Two remaining issues before we can cut 0.12: the crash in NSTextStorage deallocation and the state of the test suite. Once these are fixed I believe we're in the clear for the next release.

[mkonicek]

Now that we have a way to merge Android pull requests I will focus on getting the tests to green and making sure that the 'Getting Started' flow works on master. Once that is done and #2001 is fixed we can cut the 0.12 branch.

Just a heads up: I'll be away (vacation in Turkey) Sep 25 - 30.

[ide]

I added #2983 (Android red box when running the sample project). We've seen a couple of these errors where the Java layer expected a value of a different type and the app doesn't handle it gracefully.

[vjeux]

@mkonicek we have an end-2-end test for iOS to make sure that it doesn't instant redbox. Would be nice to add one for Android as well.

[BerndWessels]

@mkonicek I think #2983 is a real show stopper since it basically means Android development is broken.

I can retest this on my Windows machine again as soon as you've got a fix for us.

Another important issue is #2989. It is the last missing fix to finally enable RN development on Windows.

[mkonicek]

Thanks so much for sending #2989! Commented. We can cherry-pick that into the release branch.

Commented on #2983 too.

[mkonicek]

@vjeux I completely agree, adding Travis tests is on the roadmap :)

[mkonicek]

According to @tadeuzagallo #2001 is unlikely to get fixed right now, let's discuss on the issue.

[mkonicek]

Based on the above I think we're good to cut the release branch.

[mkonicek]

Just published 0.12.0-rc to npm and published Android artifacts to Bintray (with one caveat: 12b92c1).

Here are the commits the just missed the cut and we should probably cherry-pick to the 0.12-stable branch:
fcd7de5
03222d6
428f76d

[mkonicek]

I haven't published to CocoaPods - do we publish RCs?

[chirag04]

react-native-cli need to be published as well?

[ide]

Any harm in pulling everything from master over to 0.12.0-rc? Also I believe we're not doing RCs anymore and just releasing 0.12.0 (cc @brentvatne).

edit: we're publishing w/out "-rc" in the version number but the concept of an RC still exists and should be noted in the release notes. Not sure what we're doing about the latest dist-tag in npm.

[vjeux]

@chirag04 hopefully not. We designed react-native-cli to forward all the commands to the local revision so we should never ever have to update it

[chirag04]

yup. I just saw some minor changes to react-native-cli so thought maybe you guys want to publish that as well.

[mkonicek]

Hey guys, I'm back from vacation :)

Any harm in pulling everything from master over to 0.12.0-rc?

@ide That would mean we can publish a "stable" version in an unstable state, right? The point of the release branch is to let people use the code for two weeks to find as many issues as possible and only pick fixes, isn't it?

[mkonicek]

I'll pick some of the commits soon-ish, should probably pick f6ec854 too. Linux support is super cool!

[mkonicek]

I'll probably cherry-pick the fix for #2949 too.

[BerndWessels]

@mkonicek Please try to get the Windows support in too.

There is a Gist that explains all the things that need to be done and I believe that most of it already made it into master.

I can confirm that react-native 0.11.4 with the changes from this Gist works great on Windows 8.1 and 10.

To make it a perfect experience on Windows it also needs this:

@@ -184,22 +184,24 @@ function getDevToolsLauncher(options) {
+  var launched = false;
   return function(req, res, next) {
     if (req.url === '/debugger-ui') {
       var debuggerPath = path.join(__dirname, 'debugger.html');
       res.writeHead(200, {'Content-Type': 'text/html'});
       fs.createReadStream(debuggerPath).pipe(res);
     } else if (req.url === '/launch-chrome-devtools') {
       var debuggerURL = 'http://localhost:' + options.port + '/debugger-ui';
-      var script = 'launchChromeDevTools.applescript';
       console.log('Launching Dev Tools...');
-      execFile(path.join(__dirname, script), [debuggerURL], function(err, stdout, stderr) {
-        if (err) {
-          console.log('Failed to run ' + script, err);
-        }
-        console.log(stdout);
-        console.warn(stderr);
-      });
+      if (!launched) {
+        require('child_process').exec('start chrome "' + debuggerURL + '"', function (err) {
+          if (err) {
+            console.log("error", err);
+          }
+        });
+        launched = true;
+      }
       res.end('OK');
     } else {
       next();
     }
   };
 }

I took this from here but had to modify it slightly:

+        require('child_process').exec('start chrome "' + debuggerURL + '"', function (err) {

As I said it works great and hopefully you can get it into the release.

Let me know if you need somebody to test it.

Cheers
Bernd

[mkonicek]

Thanks @BerndWessels! We should probably work towards merging #2406 or your fix. I'm releasing 0.12 soon, our aim was to have Windows support in 0.13 but if there's so little remaining we could even get it to 0.12.x.

[mkonicek]

And sorry for the delay @BerndWessels. Hang tight, we definitely want Windows support too :)

[ide]

Im slating preliminary Windows support for 0.13-rc so if it doesn't land in 0.12, we'll have something for Windows users shortly after.

[mkonicek]

@BerndWessels #2406 is not making much progress. Can you submit a PR with your change? Make sure you add a platform check to only do this on Windows, we want to keep the exact same behavior we have on Mac.

See also #3348.

[BerndWessels]

@mkonicek It looks like things have already changed in master - unfortunately without taking care of Windows.

35f9ac8 9/10/2015 10:20 AM  Martín Bigio*  Unify oss and internal version of dev-tools middleware...

There is no getDevToolsLauncher in master anymore but a new getDevToolsMiddleware.js.

I will try the latest master tomorrow and see if there is anything missing that I can fix.

Cheers
Bernd

[ide]

We'll merge PRs for Windows support into the 0.13 branch, which should be going out in the next 24 hours unless something unexpected happens.

[BerndWessels]

@ide Latest master and r13 branch don't work on my Windows 10 64bit anymore.

react-native run-android gives me this:

...
...

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:preDexDebug'.
> com.android.ide.common.process.ProcessException: org.gradle.process.internal.ExecException: Process 'command 'C:\Program Files\Java\jdk1.8.0_60\bin\java.exe'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 14.358 secs
Could not install the app on the device, see the error above.

[ide]

@BerndWessels With 0.13 and future releases, Windows support and ongoing maintenance is a community responsibility. See #3348 if you are interested in helping out.

[ide]

Closing since 0.12 is out.