[Backport from 0.62-stable] Add androidx.swiperefreshlayout to template build.gradle #28071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as 2c89e51, but for template. Changelog: [Android] [Fixed] Template instacrash from missing androidx dependency
facebook-github-bot
added
the
CLA Signed
6 tasks
facebook-github-bot
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
@mdvacca is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @alloy in a1b14de. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
) Summary: Same as rickhanlonii’s 2c89e51, but for the application template. ## Changelog Changelog: [Android] [Fixed] Template instacrash from missing androidx dependency Pull Request resolved: facebook#28071 Test Plan: Apps build with the template from v0.62.0-rc.2 don’t instacrash. Differential Revision: D19908895 Pulled By: mdvacca fbshipit-source-id: 63337f4c0c0ffeb3b024682744610c7915e2b742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Same as @rickhanlonii’s 2c89e51, but for the application template.
Changelog
Changelog: [Android] [Fixed] Template instacrash from missing androidx dependency
Test Plan
Apps build with the template from v0.62.0-rc.2 don’t instacrash.