Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add eslint back to template #27983

Closed

Conversation

Naturalclar
Copy link
Contributor

@Naturalclar Naturalclar commented Feb 6, 2020

Summary

This PR is part of react-native-community/releases#157 (comment)
Adding eslint back to the template package.json

Changelog

[Internal] [Fixed] - Add eslint back in template

Test Plan

(edited)

  • npx react-native init RN062 --version 0.62.0-rc.1
  • yarn add -d eslint
  • add npm script for lint
  • yarn lint

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2020
@elicwhite
Copy link
Member

Thanks for doing this!

As a heads up, the purpose of the Test Plan section is so that the reviewer knows what you did to validate that this change was correct. If you just brought back the lines that were there before, are you sure that these versions still work? Does ESLint pass on a newly inited project still?

FWIW, I didn't really get the purpose of it until I joined Facebook :)

@Naturalclar
Copy link
Contributor Author

@TheSavior
Thanks for the information about the Test Plan! 🤗
I've written the process I've done to verify the change.
From my understanding, there are no change in the JS file from 0.62-rc.1 to the current 0.62-stable branch, so the lint check result should be the same.

@elicwhite
Copy link
Member

Great, thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Naturalclar Naturalclar deleted the chore/addEslintToTemplate branch February 7, 2020 02:55
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @Naturalclar in 8216567.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 7, 2020
alloy pushed a commit that referenced this pull request Feb 13, 2020
Summary:
This PR is part of react-native-community/releases#157 (comment)
Adding eslint back to the template package.json

[Internal] [Fixed] - Add eslint back in template
Pull Request resolved: #27983

Test Plan:
(edited)
- npx react-native init RN062 --version 0.62.0-rc.1
- yarn add -d eslint
- add npm script for lint
- yarn lint

Differential Revision: D19784567

Pulled By: TheSavior

fbshipit-source-id: 9ce24c0b674c2b1ea9fee3ed5614e8922f992f72
osdnk pushed a commit to osdnk/react-native that referenced this pull request Mar 9, 2020
Summary:
This PR is part of react-native-community/releases#157 (comment)
Adding eslint back to the template package.json

## Changelog

[Internal] [Fixed] - Add eslint back in template
Pull Request resolved: facebook#27983

Test Plan:
(edited)
- npx react-native init RN062 --version 0.62.0-rc.1
- yarn add -d eslint
- add npm script for lint
- yarn lint

Differential Revision: D19784567

Pulled By: TheSavior

fbshipit-source-id: 9ce24c0b674c2b1ea9fee3ed5614e8922f992f72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants