-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add eslint back to template #27983
Conversation
Thanks for doing this! As a heads up, the purpose of the Test Plan section is so that the reviewer knows what you did to validate that this change was correct. If you just brought back the lines that were there before, are you sure that these versions still work? Does ESLint pass on a newly FWIW, I didn't really get the purpose of it until I joined Facebook :) |
@TheSavior |
Great, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @Naturalclar in 8216567. When will my fix make it into a release? | Upcoming Releases |
Summary: This PR is part of react-native-community/releases#157 (comment) Adding eslint back to the template package.json [Internal] [Fixed] - Add eslint back in template Pull Request resolved: #27983 Test Plan: (edited) - npx react-native init RN062 --version 0.62.0-rc.1 - yarn add -d eslint - add npm script for lint - yarn lint Differential Revision: D19784567 Pulled By: TheSavior fbshipit-source-id: 9ce24c0b674c2b1ea9fee3ed5614e8922f992f72
Summary: This PR is part of react-native-community/releases#157 (comment) Adding eslint back to the template package.json ## Changelog [Internal] [Fixed] - Add eslint back in template Pull Request resolved: facebook#27983 Test Plan: (edited) - npx react-native init RN062 --version 0.62.0-rc.1 - yarn add -d eslint - add npm script for lint - yarn lint Differential Revision: D19784567 Pulled By: TheSavior fbshipit-source-id: 9ce24c0b674c2b1ea9fee3ed5614e8922f992f72
Summary
This PR is part of react-native-community/releases#157 (comment)
Adding eslint back to the template package.json
Changelog
[Internal] [Fixed] - Add eslint back in template
Test Plan
(edited)