Fix: use NODE_BINARY when starting packager #24156

Esemesek · 2019-03-26T16:50:54Z

Summary

Fix packager script to use NODE_BINARY env variable.

Should fix #22868

Changelog

[iOS] [Fixed] - Use NODE_BINARY env variable in packager.sh script

Test Plan

A launched app in Debug and Release mode and running packager.sh directly from node_modules.

cc. @Nabellaleen - since I wasn't able to reproduce the crash, can you verify that this does work in your project?

facebook-github-bot · 2019-03-26T16:51:02Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

analysis-bot

Code analysis results:

shellcheck found some issues.

scripts/packager.sh

scripts/react-native-xcode.sh

pull-bot · 2019-03-26T16:52:50Z

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against dd66191

scripts/node-binary.sh

cpojer

Please make shellcheck happy and consider my comments for the text.

facebook-github-bot · 2019-03-26T16:59:05Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

analysis-bot

Code analysis results:

shellcheck found some issues.

scripts/packager.sh

scripts/react-native-xcode.sh

Nabellaleen · 2019-03-28T18:05:17Z

@Esemesek : I take time to check this tomorrow !

cpojer

Let's ship it! Thank you.

facebook-github-bot

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

analysis-bot

Code analysis results:

shellcheck found some issues.

analysis-bot · 2019-04-10T13:16:12Z

scripts/packager.sh

@@ -13,11 +13,15 @@ PROJECT_ROOT="$THIS_DIR/../../.."
 # shellcheck source=/dev/null
 source "${THIS_DIR}/.packager.env"

+# check and assign NODE_BINARY env
+# shellcheck disable=SC1091
+source "${THIS_DIR}/node-binary.sh"


SC1090: (warning) Can't follow non-constant source. Use a directive to specify location.

analysis-bot

Code analysis results:

shellcheck found some issues.

analysis-bot · 2019-04-10T13:16:46Z

scripts/packager.sh

@@ -13,11 +13,15 @@ PROJECT_ROOT="$THIS_DIR/../../.."
 # shellcheck source=/dev/null
 source "${THIS_DIR}/.packager.env"

+# check and assign NODE_BINARY env
+# shellcheck disable=SC1091
+source "${THIS_DIR}/node-binary.sh"


SC1090: (warning) Can't follow non-constant source. Use a directive to specify location.

react-native-bot · 2019-04-10T14:45:07Z

This pull request was successfully merged by @Esemesek in 265ae58.

^{When will my fix make it into a release? | Upcoming Releases}

Summary: Fix packager script to use `NODE_BINARY` env variable. Should fix facebook#22868 [iOS] [Fixed] - Use `NODE_BINARY` env variable in `packager.sh` script Pull Request resolved: facebook#24156 Differential Revision: D14870783 Pulled By: cpojer fbshipit-source-id: 27ecf8bf59883920ab51478b8a4d8f0780e34664

Summary: I'm kicking this off to see what's the extent of failures we're going to get if we try to bump to React 18 inside RN OSS. This sync includes the following changes: - **[34aa5cfe0](facebook/react@34aa5cfe0 )**: Update local package.jsons for 18 //<Andrew Clark>// - **[e7d0053e6](facebook/react@e7d0053e6 )**: [fizz] Fix validateIterable call ([#24166](facebook/react#24166)) //<salazarm>// - **[6b85823b3](facebook/react@6b85823b3 )**: Clean up Selective Hydration / Event Replay flag ([#24156](facebook/react#24156)) //<salazarm>// Changelog: [General][Changed] - React Native sync for revisions 1159ff6...34aa5cf jest_e2e[run_all_tests] Reviewed By: cortinico Differential Revision: D35504622 fbshipit-source-id: ad0f6b42b6e03d78cd5d6ba51ce5a5730d25b167

Summary: This sync includes the following changes: - **[bd4784c8f](facebook/react@bd4784c8f )**: Revert #24236 (Don't recreate the same fallback on the client if hydrating suspends) ([#24434](facebook/react#24434)) //<dan>// - **[6d3b6d0f4](facebook/react@6d3b6d0f4 )**: forwardRef et al shouldn't affect if props reused ([#24421](facebook/react#24421)) //<Andrew Clark>// - **[bd0813766](facebook/react@bd0813766 )**: Fix: useDeferredValue should reuse previous value ([#24413](facebook/react#24413)) //<Andrew Clark>// - **[9ae80d6a2](facebook/react@9ae80d6a2 )**: Suppress hydration warnings when a preceding sibling suspends ([#24404](facebook/react#24404)) //<Josh Story>// - **[0dc4e6663](facebook/react@0dc4e6663 )**: Land enableClientRenderFallbackOnHydrationMismatch ([#24410](facebook/react#24410)) //<Andrew Clark>// - **[354772952](facebook/react@354772952 )**: Land enableSelectiveHydration flag ([#24406](facebook/react#24406)) //<Andrew Clark>// - **[392808a1f](facebook/react@392808a1f )**: Land enableClientRenderFallbackOnTextMismatch flag ([#24405](facebook/react#24405)) //<Andrew Clark>// - **[1e748b452](facebook/react@1e748b452 )**: Land enableLazyElements flag ([#24407](facebook/react#24407)) //<Andrew Clark>// - **[4175f0593](facebook/react@4175f0593 )**: Temporarily feature flag numeric fallback for symbols ([#24401](facebook/react#24401)) //<Ricky>// - **[a6d53f346](facebook/react@a6d53f346 )**: Revert "Clean up Selective Hydration / Event Replay flag ([#24156](facebook/react#24156))" ([#24402](facebook/react#24402)) //<Ricky>// - **[ab9cdd34f](facebook/react@ab9cdd34f )**: Bugfix: In legacy mode, call suspended tree's unmount effects when it is deleted ([#24400](facebook/react#24400)) //<Andrew Clark>// - **[168da8d55](facebook/react@168da8d55 )**: Fix typo that happened during rebasing //<Andrew Clark>// - **[8bc527a4c](facebook/react@8bc527a4c )**: Bugfix: Fix race condition between interleaved and non-interleaved updates ([#24353](facebook/react#24353)) //<Andrew Clark>// - **[f7cf077cc](facebook/react@f7cf077cc )**: [Transition Tracing] Add Offscreen Queue ([#24341](facebook/react#24341)) //<Luna Ruan>// - **[4fc394bbe](facebook/react@4fc394bbe )**: Fix suspense fallback throttling ([#24253](facebook/react#24253)) //<sunderls>// - **[80170a068](facebook/react@80170a068 )**: Match bundle.name and match upper case entry points ([#24346](facebook/react#24346)) //<Sebastian Markbåge>// - **[fea6f8da6](facebook/react@fea6f8da6 )**: [Transition Tracing] Add transition to OffscreenState and pendingSuspenseBoundaries to RootState ([#24340](facebook/react#24340)) //<Luna Ruan>// - **[8e2f9b086](facebook/react@8e2f9b086 )**: move passive flag ([#24339](facebook/react#24339)) //<Luna Ruan>// - **[55a21ef7e](facebook/react@55a21ef7e )**: fix pushTransition for transition tracing ([#24338](facebook/react#24338)) //<Luna Ruan>// - **[069d23bb7](facebook/react@069d23bb7 )**: [eslint-plugin-exhaustive-deps] Fix exhaustive deps check for unstable vars ([#24343](facebook/react#24343)) //<Afzal Sayed>// - **[4997515b9](facebook/react@4997515b9 )**: Point useSubscription to useSyncExternalStore shim ([#24289](facebook/react#24289)) //<dan>// - **[01e2bff1d](facebook/react@01e2bff1d )**: Remove unnecessary check ([#24332](facebook/react#24332)) //<zhoulixiang>// - **[d9a0f9e20](facebook/react@d9a0f9e20 )**: Delete create-subscription folder ([#24288](facebook/react#24288)) //<dan>// - **[f993ffc51](facebook/react@f993ffc51 )**: Fix infinite update loop that happens when an unmemoized value is passed to useDeferredValue ([#24247](facebook/react#24247)) //<Andrew Clark>// - **[fa5800226](facebook/react@fa5800226 )**: [Fizz] Pipeable Stream Perf ([#24291](facebook/react#24291)) //<Josh Story>// - **[0568c0f8c](facebook/react@0568c0f8c )**: Replace zero with NoLanes for consistency in FiberLane ([#24327](facebook/react#24327)) //<Leo>// - **[e0160d50c](facebook/react@e0160d50c )**: add transition tracing transitions stack ([#24321](facebook/react#24321)) //<Luna Ruan>// - **[b0f13e5d3](facebook/react@b0f13e5d3 )**: add pendingPassiveTransitions ([#24320](facebook/react#24320)) //<Luna Ruan>// Changelog: [General][Changed] - React Native sync for revisions 60e63b9...bd4784c jest_e2e[run_all_tests] Reviewed By: kacieb Differential Revision: D35899012 fbshipit-source-id: 86a885e336fca9f0efa80cd2b8ca040f2cb53853

Summary: I'm kicking this off to see what's the extent of failures we're going to get if we try to bump to React 18 inside RN OSS. This sync includes the following changes: - **[34aa5cfe0](facebook/react@34aa5cfe0 )**: Update local package.jsons for 18 //<Andrew Clark>// - **[e7d0053e6](facebook/react@e7d0053e6 )**: [fizz] Fix validateIterable call ([facebook#24166](facebook/react#24166)) //<salazarm>// - **[6b85823b3](facebook/react@6b85823b3 )**: Clean up Selective Hydration / Event Replay flag ([facebook#24156](facebook/react#24156)) //<salazarm>// Changelog: [General][Changed] - React Native sync for revisions 1159ff6...34aa5cf jest_e2e[run_all_tests] Reviewed By: cortinico Differential Revision: D35504622 fbshipit-source-id: ad0f6b42b6e03d78cd5d6ba51ce5a5730d25b167

Fix: use NODE_BINARY when starting packager

d4877c6

Esemesek requested review from cpojer and hramos as code owners March 26, 2019 16:50

analysis-bot suggested changes Mar 26, 2019

View reviewed changes

scripts/packager.sh Show resolved Hide resolved

scripts/react-native-xcode.sh Show resolved Hide resolved

cpojer reviewed Mar 26, 2019

View reviewed changes

scripts/node-binary.sh Outdated Show resolved Hide resolved

cpojer reviewed Mar 26, 2019

View reviewed changes

scripts/node-binary.sh Outdated Show resolved Hide resolved

cpojer reviewed Mar 26, 2019

View reviewed changes

scripts/node-binary.sh Outdated Show resolved Hide resolved

react-native-bot added Tech: Bundler 📦 This issue is related to the bundler (Metro, Haul, etc) used. Includes Changelog labels Mar 26, 2019

cpojer reviewed Mar 26, 2019

View reviewed changes

scripts/node-binary.sh Outdated Show resolved Hide resolved

cpojer suggested changes Mar 26, 2019

View reviewed changes

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 26, 2019

Shellcheck and review suggestions

0a1d8b6

analysis-bot suggested changes Mar 26, 2019

View reviewed changes

scripts/packager.sh Show resolved Hide resolved

scripts/react-native-xcode.sh Show resolved Hide resolved

Make shellcheck happy

a4714a4

cpojer added 2 commits April 10, 2019 14:13

Update node-binary.sh

35b3312

Update node-binary.sh

dd66191

cpojer approved these changes Apr 10, 2019

View reviewed changes

facebook-github-bot approved these changes Apr 10, 2019

View reviewed changes

analysis-bot suggested changes Apr 10, 2019

View reviewed changes

facebook-github-bot closed this in 265ae58 Apr 10, 2019

react-native-bot added the Merged This PR has been merged. label Apr 10, 2019

aryo mentioned this pull request Oct 17, 2019

Can't find 'node' binary to build React Native bundle #22918

Closed

alloy mentioned this pull request Sep 15, 2020

feat: Enable Hermes to work on iOS #29914

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: use NODE_BINARY when starting packager #24156

Fix: use NODE_BINARY when starting packager #24156

Esemesek commented Mar 26, 2019 •

edited

Loading

facebook-github-bot commented Mar 26, 2019

analysis-bot left a comment

pull-bot commented Mar 26, 2019 •

edited

Loading

cpojer left a comment

facebook-github-bot commented Mar 26, 2019

analysis-bot left a comment

Nabellaleen commented Mar 28, 2019

cpojer left a comment

facebook-github-bot left a comment

analysis-bot left a comment

analysis-bot Apr 10, 2019

analysis-bot left a comment

analysis-bot Apr 10, 2019

react-native-bot commented Apr 10, 2019

Fix: use NODE_BINARY when starting packager #24156

Fix: use NODE_BINARY when starting packager #24156

Conversation

Esemesek commented Mar 26, 2019 • edited Loading

Summary

Changelog

Test Plan

facebook-github-bot commented Mar 26, 2019

analysis-bot left a comment

Choose a reason for hiding this comment

pull-bot commented Mar 26, 2019 • edited Loading

cpojer left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Mar 26, 2019

analysis-bot left a comment

Choose a reason for hiding this comment

Nabellaleen commented Mar 28, 2019

cpojer left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

analysis-bot left a comment

Choose a reason for hiding this comment

analysis-bot Apr 10, 2019

Choose a reason for hiding this comment

analysis-bot left a comment

Choose a reason for hiding this comment

analysis-bot Apr 10, 2019

Choose a reason for hiding this comment

react-native-bot commented Apr 10, 2019

Esemesek commented Mar 26, 2019 •

edited

Loading

pull-bot commented Mar 26, 2019 •

edited

Loading