improve RTL #24069
Closed
improve RTL #24069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
michalchudziak
approved these changes
Mar 20, 2019
facebook-github-bot
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @dulmandakh in b3c7496. When will my fix make it into a release? | Upcoming Releases |
kelset
pushed a commit
that referenced
this pull request
Mar 29, 2019
Summary: Google recommends to use Gravity.START and Gravity.END instead of Gravity.LEFT and Gravity.RIGHT to support RTL better. [Android] [Changed] - Improve RTL support Pull Request resolved: #24069 Differential Revision: D14541569 Pulled By: cpojer fbshipit-source-id: 5c104d8bd666e1270d5410216c7f2efa6152692a
cpojer
added a commit
to cpojer/react-native
that referenced
this pull request
Apr 24, 2019
This reverts commit b3c7496.
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 24, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
We all make mistakes, and this is one of them while I was trying to improve
React Native on Android. I followed Google's recommendation, but it didn't
worked well on React Natice. Lessons learned, I should've tested it more
and should've asked someone with RTL experience to review. So sorry about
it.
Also, I would like ask you and others to participate in development, review
PRs that might affect your apps or areas you have experience with.
|
|
@dulmandakh OK , no problem! |
grabbou
pushed a commit
that referenced
this pull request
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Google recommends to use Gravity.START and Gravity.END instead of Gravity.LEFT and Gravity.RIGHT to support RTL better.
Changelog
[Android] [Changed] - Improve RTL support
Test Plan
CI is green, and RNTester works as expected