Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "improve RTL (#24069)" #24580

Closed
wants to merge 2 commits into from
Closed

Revert "improve RTL (#24069)" #24580

wants to merge 2 commits into from

Conversation

cpojer
Copy link
Contributor

@cpojer cpojer commented Apr 24, 2019

Summary

This reverts commit b3c7496.

Fixes #24267

Changelog

[Android] [Fixed] - Invalid text alignment for RTL fonts.

Test Plan

Revert

@cpojer cpojer requested a review from dulmandakh April 24, 2019 08:52
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 24, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @cpojer in 8d3e168.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 24, 2019
@sm2017
Copy link
Contributor

sm2017 commented Apr 30, 2019

@cpojer I have some problem , I am using 0.59.2 that have onLongPress bug fixed in 0.59.4 , You approve buggy #24069 and released in 0.59.3 , 0.59.5 not included Revert "improve RTL (#24069)" So there is no react native version fixed both onLongPress and RTL bug,

When you release a version included #24580??

grabbou pushed a commit that referenced this pull request May 6, 2019
Summary:
This reverts commit b3c7496.

Fixes #24267

[Android] [Fixed] - Invalid text alignment for RTL fonts.
Pull Request resolved: #24580

Differential Revision: D15061667

Pulled By: cpojer

fbshipit-source-id: 6d02c9e938f1f8630ba691f57bdf79fd57db3bb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.59.3 Text component on Android getting other side on textAlign
5 participants