Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable full podspec CI build and make RCTAnimation subspec green. #13217

Closed

Conversation

alloy
Copy link
Contributor

@alloy alloy commented Mar 30, 2017

Fixes #13198.

This enables all subspecs defined in the podspec to be built individually, which does take a lot longer but ensures build failures in the smaller subspecs are caught too.

Also fixes a build failure in RCTAnimation by making the import consistent with other imports in the same area of the codebase.

/cc @janicduplessis @mkonicek

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 30, 2017
@ptomasroos
Copy link
Contributor

Just great! Tremendously great (never gets old)

@janicduplessis
Copy link
Contributor

Could you make it work without changing the import, see 1d37dd0#commitcomment-21529221

@alloy
Copy link
Contributor Author

alloy commented Mar 30, 2017

Thanks for the pointer! Will take a look-see.

@janicduplessis
Copy link
Contributor

You should be able to the the same thing we do to get namespaces <React/...> imports working, thats what I did for the normal xcode build. I know nothing about podspecs so I cant really help more here.

@ptomasroos
Copy link
Contributor

Do you need a hand here @alloy or just very busy at the moment? I think it would make sense to try to fix this pretty soon since master is broken because of this.

@alloy
Copy link
Contributor Author

alloy commented Apr 19, 2017

I’m extremely busy indeed. I did try a few different approaches, but none yielded any success. I have one more idea that I think might actually be successful and will put at the top of my TODO list, but it’s probably still going to be tomorrow/Friday before I get to it.

@ptomasroos
Copy link
Contributor

Cool! Take care we maintain our own branch with your fix so no special rush.

@alloy
Copy link
Contributor Author

alloy commented Apr 19, 2017

🙏🏽

@willdawsonme
Copy link

willdawsonme commented May 1, 2017

Any update on this? Running into the RCTValueAnimatedNode.h import issue on 0.44.0.

@vjeranc
Copy link
Contributor

vjeranc commented May 4, 2017

I've added a simple, yet more acceptable PR #13785

facebook-github-bot pushed a commit that referenced this pull request May 9, 2017
Summary:
Fixes issue described #13198

Simpler, compared to #13217

Build no longer fails on not being able to find `RCTAnimation/RCTValueAnimatedNode.h`.
Closes #13785

Differential Revision: D5017734

Pulled By: javache

fbshipit-source-id: e398f74e0fbb1a8f5a43d0a80a4cd3a3587c81b3
@ptomasroos
Copy link
Contributor

@hramos @alloy feel free to close this as its fixed since of 7b7d6bb

@vongohren
Copy link

Im running with "react-native": "0.47.0-rc.5", and still experiencing this problem. Why?
That mentioned commit should be in this tag.

@vjeranc
Copy link
Contributor

vjeranc commented Jul 31, 2017

@vongohren Problem seems to be nontrivial because on my project 0.45.1 works fine, just as the applied fix did on 0.44.0.

@vongohren
Copy link

@vjeranc what do you mean? That I should not experience it?

@dushaobindoudou
Copy link

0.45.1 not work fine

@msand
Copy link
Contributor

msand commented Mar 10, 2018

This should probably be solved using this approach: #13198 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][cocoapods] 'RCTAnimation/RCTValueAnimatedNode.h' file not found
10 participants