-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable full podspec CI build and make RCTAnimation subspec green. #13217
Enable full podspec CI build and make RCTAnimation subspec green. #13217
Conversation
Just great! Tremendously great (never gets old) |
Could you make it work without changing the import, see 1d37dd0#commitcomment-21529221 |
Thanks for the pointer! Will take a look-see. |
You should be able to the the same thing we do to get namespaces <React/...> imports working, thats what I did for the normal xcode build. I know nothing about podspecs so I cant really help more here. |
Do you need a hand here @alloy or just very busy at the moment? I think it would make sense to try to fix this pretty soon since master is broken because of this. |
I’m extremely busy indeed. I did try a few different approaches, but none yielded any success. I have one more idea that I think might actually be successful and will put at the top of my TODO list, but it’s probably still going to be tomorrow/Friday before I get to it. |
Cool! Take care we maintain our own branch with your fix so no special rush. |
🙏🏽 |
Any update on this? Running into the |
I've added a simple, yet more acceptable PR #13785 |
Im running with |
@vongohren Problem seems to be nontrivial because on my project 0.45.1 works fine, just as the applied fix did on 0.44.0. |
@vjeranc what do you mean? That I should not experience it? |
0.45.1 not work fine |
This should probably be solved using this approach: #13198 (comment) |
Fixes #13198.
This enables all subspecs defined in the podspec to be built individually, which does take a lot longer but ensures build failures in the smaller subspecs are caught too.
Also fixes a build failure in RCTAnimation by making the import consistent with other imports in the same area of the codebase.
/cc @janicduplessis @mkonicek