Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React.podspec fix for RCTAnimation header issue #13785

Closed
wants to merge 1 commit into from
Closed

React.podspec fix for RCTAnimation header issue #13785

wants to merge 1 commit into from

Conversation

vjeranc
Copy link
Contributor

@vjeranc vjeranc commented May 4, 2017

Fixes issue described #13198

Simpler, compared to #13217

Build no longer fails on not being able to find RCTAnimation/RCTValueAnimatedNode.h.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

This was referenced May 4, 2017
Closed
Closed
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2017
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@janicduplessis
Copy link
Contributor

janicduplessis commented May 4, 2017 •
edited
Loading

@alloy Does that look good? Seems fine to me but I know nothing about podspecs :)

@alloy
Copy link
Contributor

alloy commented May 6, 2017

@vjeranc Does it build when using use_frameworks! ?

@vjeranc
Copy link
Contributor Author

vjeranc commented May 6, 2017

@alloy it does work. React.framework and Yoga.framework seem to get created and build succeeds.

@atkit
Copy link

atkit commented May 6, 2017

Solution of this pull request works for me (in a hybrid dark brownfield app).
But we don't use use_frameworks! yet.

@nfcampos
Copy link

nfcampos commented May 6, 2017

this works for me with use_frameworks!

@alloy
Copy link
Contributor

alloy commented May 6, 2017

That's good enough for me for now then. Thanks @vjeranc!

@janicduplessis
Copy link
Contributor

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

@janicduplessis has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jeanregisser
Copy link
Contributor

Great! Is this going to land in a 0.44.x bug fix release?
Right now the released v0.44.0 can't be used with CocoaPods because of this issue.

@janicduplessis
Copy link
Contributor

@javache Could you try landing this

@janicduplessis
Copy link
Contributor

I'll check if we can include this in a 0.44 patch

@nartawak
Copy link

@janicduplessis Do you have any news for the 0.44 patch ?

@cinder92
Copy link

@janicduplessis yes please, i want to upload my app :sad: from my job, we have a dead line... any update for 0.44 fix?

@skv-headless
Copy link
Contributor

skv-headless commented May 17, 2017 •
edited
Loading

It doesn't work with use_frameworks!. Here is proof https://github.com/skv-headless/TestPodspec
cocoapods 1.2.0 version

@vjeranc
Copy link
Contributor Author

vjeranc commented May 17, 2017

I built a clean react-native project with use_frameworks!.

You are using third party podspecs there. It might be that some of them don't work with it.

For example, google maps for ios does not work with use_frameworks! without some manual adjustments.

@skv-headless
Copy link
Contributor

  1. seems that after 5aca739 I have to use use_frameworks! otherwise it doesn't compile
  2. I have exactly the same error 'RCTAnimation/RCTValueAnimatedNode.h' file not found in my example project

@vjeranc
Copy link
Contributor Author

vjeranc commented May 17, 2017

that commit does not seem to have RCTAnimation changes from this one.

https://github.com/facebook/react-native/blob/5aca739cc25949eebc04a0309c2944f92b5b5391/React.podspec

@ceyhun ceyhun mentioned this pull request Jun 21, 2017
Closed
facebook-github-bot pushed a commit that referenced this pull request Oct 13, 2018
@yungsters @facebook-github-bot
React sync for revisions d836010...4773fdf
8325e09 
Summary:
@public
This sync includes the following changes:
- **[4773fdf7c](facebook/react@4773fdf7c)**: Deprecate findDOMNode in StrictMode (#13841) //<Sebastian Markbåge>//
- **[c9be16f5b](facebook/react@c9be16f5b)**: [scheduler] Rename priority levels (#13842) //<Andrew Clark>//
- **[3b7ee2692](facebook/react@3b7ee2692)**: Deprecate context object as a consumer and add a warning message (#13829) //<Dominic Gannaway>//
- **[8ca8a594e](facebook/react@8ca8a594e)**: Error gracefully for unsupported SSR features (#13839) //<Dan Abramov>//
- **[4a635785f](facebook/react@4a635785f)**: Fix User Timing oddities with Suspense, pure, and lazy (#13833) //<Dan Abramov>//
- **[a165cf747](facebook/react@a165cf747)**: Renamed 4 Internal React Modules //<Nadia Osipova>//
- **[a68ca9a5b](facebook/react@a68ca9a5b)**: React.pure automatically forwards ref (#13822) //<Sophie Alpert>//
- **[c73497c3c](facebook/react@c73497c3c)**: Update bundle sizes for 16.6.0-alpha.8af6728 release //<Dan Abramov>//
- **[1a57dc668](facebook/react@1a57dc668)**: Updating dependencies for react-noop-renderer //<Dan Abramov>//
- **[77f8dfd81](facebook/react@77f8dfd81)**: Updating package versions for release 16.6.0-alpha.8af6728 //<Dan Abramov>//
- **[8af6728c6](facebook/react@8af6728c6)**: Enable Suspense + rename Placeholder (#13799) //<Dan Abramov>//
- **[f47a958ea](facebook/react@f47a958ea)**: Don’t add onclick listener to React root (#13778) //<Philipp>//
- **[b2cea9078](facebook/react@b2cea9078)**: [scheduler] Eagerly schedule rAF at beginning of frame (#13785) //<Andrew Clark>//
- **[e2e7cb9f4](facebook/react@e2e7cb9f4)**: [scheduler] add a test documenting current behavior (#13687) //<plievone>//

Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions d836010...4773fdf

Reviewed By: acdlite

Differential Revision: D10350869

fbshipit-source-id: ea8ad4b5d914c870be1fc80aa1005b224d37f5e5
kelset pushed a commit that referenced this pull request Nov 9, 2018
@yungsters @kelset
React sync for revisions d836010...4773fdf
19c8164 
Summary:
@public
This sync includes the following changes:
- **[4773fdf7c](facebook/react@4773fdf7c)**: Deprecate findDOMNode in StrictMode (#13841) //<Sebastian Markbåge>//
- **[c9be16f5b](facebook/react@c9be16f5b)**: [scheduler] Rename priority levels (#13842) //<Andrew Clark>//
- **[3b7ee2692](facebook/react@3b7ee2692)**: Deprecate context object as a consumer and add a warning message (#13829) //<Dominic Gannaway>//
- **[8ca8a594e](facebook/react@8ca8a594e)**: Error gracefully for unsupported SSR features (#13839) //<Dan Abramov>//
- **[4a635785f](facebook/react@4a635785f)**: Fix User Timing oddities with Suspense, pure, and lazy (#13833) //<Dan Abramov>//
- **[a165cf747](facebook/react@a165cf747)**: Renamed 4 Internal React Modules //<Nadia Osipova>//
- **[a68ca9a5b](facebook/react@a68ca9a5b)**: React.pure automatically forwards ref (#13822) //<Sophie Alpert>//
- **[c73497c3c](facebook/react@c73497c3c)**: Update bundle sizes for 16.6.0-alpha.8af6728 release //<Dan Abramov>//
- **[1a57dc668](facebook/react@1a57dc668)**: Updating dependencies for react-noop-renderer //<Dan Abramov>//
- **[77f8dfd81](facebook/react@77f8dfd81)**: Updating package versions for release 16.6.0-alpha.8af6728 //<Dan Abramov>//
- **[8af6728c6](facebook/react@8af6728c6)**: Enable Suspense + rename Placeholder (#13799) //<Dan Abramov>//
- **[f47a958ea](facebook/react@f47a958ea)**: Don’t add onclick listener to React root (#13778) //<Philipp>//
- **[b2cea9078](facebook/react@b2cea9078)**: [scheduler] Eagerly schedule rAF at beginning of frame (#13785) //<Andrew Clark>//
- **[e2e7cb9f4](facebook/react@e2e7cb9f4)**: [scheduler] add a test documenting current behavior (#13687) //<plievone>//

Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions d836010...4773fdf

Reviewed By: acdlite

Differential Revision: D10350869

fbshipit-source-id: ea8ad4b5d914c870be1fc80aa1005b224d37f5e5
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@yungsters @facebook-github-bot
React sync for revisions d836010...4773fdf
492b676 
Summary:
@public
This sync includes the following changes:
- **[4773fdf7c](facebook/react@4773fdf7c)**: Deprecate findDOMNode in StrictMode (facebook#13841) //<Sebastian Markbåge>//
- **[c9be16f5b](facebook/react@c9be16f5b)**: [scheduler] Rename priority levels (facebook#13842) //<Andrew Clark>//
- **[3b7ee2692](facebook/react@3b7ee2692)**: Deprecate context object as a consumer and add a warning message (facebook#13829) //<Dominic Gannaway>//
- **[8ca8a594e](facebook/react@8ca8a594e)**: Error gracefully for unsupported SSR features (facebook#13839) //<Dan Abramov>//
- **[4a635785f](facebook/react@4a635785f)**: Fix User Timing oddities with Suspense, pure, and lazy (facebook#13833) //<Dan Abramov>//
- **[a165cf747](facebook/react@a165cf747)**: Renamed 4 Internal React Modules //<Nadia Osipova>//
- **[a68ca9a5b](facebook/react@a68ca9a5b)**: React.pure automatically forwards ref (facebook#13822) //<Sophie Alpert>//
- **[c73497c3c](facebook/react@c73497c3c)**: Update bundle sizes for 16.6.0-alpha.8af6728 release //<Dan Abramov>//
- **[1a57dc668](facebook/react@1a57dc668)**: Updating dependencies for react-noop-renderer //<Dan Abramov>//
- **[77f8dfd81](facebook/react@77f8dfd81)**: Updating package versions for release 16.6.0-alpha.8af6728 //<Dan Abramov>//
- **[8af6728c6](facebook/react@8af6728c6)**: Enable Suspense + rename Placeholder (facebook#13799) //<Dan Abramov>//
- **[f47a958ea](facebook/react@f47a958ea)**: Don’t add onclick listener to React root (facebook#13778) //<Philipp>//
- **[b2cea9078](facebook/react@b2cea9078)**: [scheduler] Eagerly schedule rAF at beginning of frame (facebook#13785) //<Andrew Clark>//
- **[e2e7cb9f4](facebook/react@e2e7cb9f4)**: [scheduler] add a test documenting current behavior (facebook#13687) //<plievone>//

Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions d836010...4773fdf

Reviewed By: acdlite

Differential Revision: D10350869

fbshipit-source-id: ea8ad4b5d914c870be1fc80aa1005b224d37f5e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@vjeranc @facebook-github-bot @janicduplessis @alloy @atkit @nfcampos @jeanregisser @nartawak @cinder92 @skv-headless