Updates from Wed 6 May #1184
Merged
Updates from Wed 6 May #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `XMLHttpRequest.getResponseHeader` is case-insensitive, therefor the React-Native implementation needs to mimic this behavior as to not break libraries that are dependent on this. There is a corresponding issue in `superagent` but this is the root cause (ladjs/superagent#636). Closes facebook#1138 Github Author: Ryan Pastorelle <rpastorelle@yahoo.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: Hi! I have the same problem as described here facebook#297 It could occurs after restarting `packager.sh` or `debuger-ui` page. I found simple solution that works for me, but I am not 100% sure it will works for any user with this problem. How could this be tested automatically? Closes facebook#1101 Github Author: Evgen Filatov <evgen.filatov@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line.
Summary: jumpN will call enableScene for the dest scene, which makes sure the scene can be made visible, but we need to avoid resetting the opacity for it when it is already the presented scene. There is already a check to make sure we don't reset opacity for the transitioningFrom scene. @public Test Plan: Fixes the issue on Android device when jumping to a scene that is already presented
Summary: @public Currently, every time we call into the packager we have to change the ulimit to make sure we don't hit the EMFILE error (the packager uses as much concurrency as possible). Using graceful-fs, the fs module -- with monkey patching -- becomes intelligent enough to recover from EMFILE errors. Test Plan: * set `ulimit -n 256* * start server * request from your browser: http://localhost:8081/RKJSModules/MainBundle/CatalystBundle.includeRequire.bundle * it works
Summary: The default initialRoute was the first route, but it makes more sense for the default initialRoute to be the last route in the initialRouteStack. Updated the docs to reflect that. @public Test Plan: Updated call sites and checked that they work. Not many places use initialRouteStack yet.
facebook-github-bot
added
the
CLA Signed
|
Thanks @nicklockwood! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.