Force responseHeaders to lower case to respect case-insensitivity
#1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
rpastorelle
changed the title
responseHeaders to lower case to enforce case-insensitivityresponseHeaders to lower case to respect case-insensitivity
| // Headers should be case-insensitive | ||
| for (var header in responseHeaders) { | ||
| responseHeaders[header.toLowerCase()] = responseHeaders[header]; | ||
| delete responseHeaders[header]; |
There was a problem hiding this comment.
When the header is already in lower case this will remove it.
…esponse headers This prevents already-lower-cased headers from being deleted (which the previous commit was doing)
|
@frantic Thanks. The issue you mentioned should be taken care of with the latest commit. |
|
@rpastorelle - thanks, will pull this in soon |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
Update showcase.json
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
May 13, 2022
…m-validation Add debug logging to -[RCTSRWebSocket _connect]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XMLHttpRequest.getResponseHeaderis case-insensitive, therefor the React-Native implementation needs to mimic this behavior as to not break libraries that are dependent on this.There is a corresponding issue in
superagentbut this is the root cause (ladjs/superagent#636).