Failed to set Content-Type internally with the xhr's getResponseHeader

[rpastorelle]

In response to an issue in which res.body is null ...superagent Failed to correctly set Content-Type header from the xhr with getResponseHeader due to case-sensitivity

[slooker]

This solved the problem for me.

[defunctzombie]

sounds like react-native is at fault here? headers are not case sensitive as far as I am aware

[slooker]

I'm not sure if it's react-native's fault or not, but according to https://tools.ietf.org/html/rfc7230#appendix-A.2 section 3.2, headers definitely should be case-insensitive.

[dhrrgn]

@slooker @defunctzombie It is true that getResponseHeader should be case-insensitive. However, this is probably an issue with JavascriptCore (which is the engine that ReactNative uses), thus cannot be fixed by the Facebook team (without an upstream fix). I think the best solution here is just to use the correct case (per the spec).

[defunctzombie]

IMO the best solution is for the engine to the fixed. This has not been a
problem in any other browser to this point. If it was not in the spec I
might feel differently but given that all the other browsers behave
correctly I am hesitant to fix this since it seems like a bug in
JavascriptCore (not exactly sure what that is by sounds relatively new and
likely to fix this bug)

On Monday, May 4, 2015, Dan Horrigan notifications@github.com wrote:

@slooker https://github.com/slooker @defunctzombie
https://github.com/defunctzombie It is true that getResponseHeader
should be case-insensitive. However, this is probably an issue with
JavascriptCore (which is the engine that ReactNative uses), thus cannot be
fixed by the Facebook team (without an upstream fix). I think the best
solution here is just to use the correct case.

—
Reply to this email directly or view it on GitHub
#638 (comment)
.

[defunctzombie]

I would at least file an issue there and see how receptive they are. If for
some reason they are not receptive then we can revisit.

On Monday, May 4, 2015, Dan Horrigan notifications@github.com wrote:

@slooker https://github.com/slooker @defunctzombie
https://github.com/defunctzombie It is true that getResponseHeader
should be case-insensitive. However, this is probably an issue with
JavascriptCore (which is the engine that ReactNative uses), thus cannot be
fixed by the Facebook team (without an upstream fix). I think the best
solution here is just to use the correct case.

—
Reply to this email directly or view it on GitHub
#638 (comment)
.

[slooker]

I agree, we should absolutely post it as an issue there. Getting it fixed where it's actually broken is a better option than applying a bandaid further down.

[rpastorelle]

I don't see the harm in using the typical case for this header. It adds no extra code and still fixes the issue.

[rpastorelle]

I found & fixed the root cause in React Native — facebook/react-native#1138

[defunctzombie]

👍