You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates Docusaurus to latest beta (beta.18) and most of the other dependencies.
Due to changes in Docusaurus code, I had to adjust the config and add a bunch of fixes to our custom styles, which become broken after the update. I also had to duplicate the GA move in the config, otherwise the website won't start.
Test plan
I have run the updated version of the website on localhost and I used the currently shipped website as a 1:1 comparison, so the style issues was easier to spot, however, there still might be small display problems which I was not able to catch. If you see any regression in preview deploy, please let me know!
I think this looks good! Are there particular places we should look for breakages? I guess, also should we confirm that GA tracking is working (tbh not sure how to do that)
Are there particular places we should look for breakages?
Generally every layout have at least one issue, sidebars too, only home page looks correct after upgrade, so it's hard to point on the specific thing. I usually test few pages, with focus on the origin diversity:
homage (custom JS)
versioned doc page (docs plugin)
blog post list and blog post (blog plugin)
community page (custom MD)
I guess, also should we confirm that GA tracking is working (tbh not sure how to do that)
The fix has been deployed yesterday in separate PR, so you probably should see a data spike on the GA dashboard now, if everything is working correctly.
I have fixed the mobile menu hover issue and the deploy preview should be updated. I have set the hover color, to one which we use for highlighting the active page in the menu.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why & how
Superseeds:
This PR updates Docusaurus to latest beta (
beta.18) and most of the other dependencies.Due to changes in Docusaurus code, I had to adjust the config and add a bunch of fixes to our custom styles, which become broken after the update. I also had to duplicate the GA move in the config, otherwise the website won't start.
Test plan
I have run the updated version of the website on
localhostand I used the currently shipped website as a 1:1 comparison, so the style issues was easier to spot, however, there still might be small display problems which I was not able to catch. If you see any regression in preview deploy, please let me know!