-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: upgrade Docusaurus #3022
WIP: upgrade Docusaurus #3022
Conversation
"@docusaurus/core": "0.0.0-4738", | ||
"@docusaurus/plugin-pwa": "0.0.0-4738", | ||
"@docusaurus/preset-classic": "0.0.0-4738", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we wait until next beta
is released? The class name issue doesn't seems that crucial to stick to nightlines. 😅
Also Algolia and GA stuff should not be linked to the CSS problems, right? Saying that, I was planning to upgrade to latest beta this weekend, so if changing that to beta.17
also helps that would be fine.
✅ Deploy Preview for react-native ready! 🔨 Explore the source changes: 08072e9 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-native/deploys/6234ceec73a8c900085b3ef0 😎 Browse the preview: https://deploy-preview-3022--react-native.netlify.app |
Looking at the deploy, there are few thing which doesn't seems correct right now:
Also, personally I think that including the page name in this navigation is redundant and looks a bit weird, when title is listed twice, and both those text are non-interactable. Besides the "home" link (which do the same as logo) the new component doesn't add any other function, besides displaying navigation structure: Is it possible to turned this feature off? Not sure if we want that, but it would be nice to know. |
Thanks for the review This is a WIP PR to help you with the breaking changes and so that I know what else breaks on upgrade. I'll be on holiday and will do a release before so if you want to give it a try until then let me know, otherwise we'll wait 2 weeks 😄 |
That's because the RN website currently doesn't take advantage of the new category index pages. If a category has a link associated, the respective breadcrumb item will be clickable. But given the flat nature of the website's navigation system, maybe the breadcrumbs aren't useful at all? |
The color mode toggle hover style is |
Thanks for the explanation @Josh-Cena! Maybe we leverage this feature in the future, while reworking Architecture and Contributing parts, but for now I have disabled them in my PR, via Other issues are also fixed in my PR, there were few more than reported in there, the most problematic was not working chevron displayed, even when |
Replaced by #3059 |
Upgrade of Docusaurus:
WIP as there are some remaining CSS issues to fix