Skip to content

Conversation

@tcuongd
Copy link
Collaborator

@tcuongd tcuongd commented May 5, 2022

cmdstanpy >=1.0.1 (requirement introduced #2148) requires Python >= 3.7: https://github.com/stan-dev/cmdstanpy/releases/tag/v1.0.1

Wheel build test: https://github.com/facebook/prophet/actions/runs/2275140778

@tcuongd
Copy link
Collaborator Author

tcuongd commented May 5, 2022

@WardBrian I see a lot of packages requiring Python >= 3.7 nowadays, so this change shouldn't be controversial

@tcuongd
Copy link
Collaborator Author

tcuongd commented May 5, 2022

Hmm running into rate limiting issues again while downloading cmdstanpy to build the wheel...

 WARNING:cmdstanpy:Cannot connect to CmdStan github repo.
  Cannot connect to github.
  Cannot connect to CmdStan github repo.
  HTTP Error 403: rate limit exceeded

@WardBrian
Copy link
Collaborator

Does this action have a GitHub token set in the environment? I believe that raises the rate limit considerably

@tcuongd
Copy link
Collaborator Author

tcuongd commented May 5, 2022

It doesn't, and I think I need elevated permissions to add one. Good to know though -- I'll raise that.

I just hit re-run on the specific job and everything ran fine (we have cmdstanpy-only wheels now, woohoo!). We might just have to keep hitting retry if the wheel build fails for now.

@tcuongd tcuongd merged commit b7d5ec4 into main May 5, 2022
@tcuongd tcuongd deleted the tcuongd-remove-36-wheel branch May 5, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants