-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Remove pystan, leave backend abstraction for now #2148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
After this is merged you the build_wheel can run and build for python 3.6-3.10. Until PyPi is updated that link will be the best bet |
|
This is great, I can confirm checking out this PR solves all the build issues on Mac with python 3.9+. It would be great to have this merged, and perhaps a new pypi packaged released, as the fact that the "official" pypi release doesn't work with any recent python is not great. IMO, the code refactoring can be postponed as it will not alter any functionality. |
|
I think leaving the backend code for now could even be useful if things like #1973 get another look |
|
This looks great! Looking forward to this being merged and Prophet released to PyPi again |
|
@tcuongd are you able to review this? I know there are some permissions issues blocking a PyPi release as well, but this is one of the final roadblocks as I understand |
|
Thank you! I think Prophet really need this because pystan is really problematic to install. |
|
Any updates on this issue? We have had all our environments pulling prophet to this PR for a few weeks now and everything is working fine. It would be great if an "official" release could be made |
|
@tcuongd kind ping :) |
|
Yep this LGTM, thanks heaps! I'll trigger a |
|
Successfully built wheels without pystan: https://github.com/facebook/prophet/actions/runs/2275140778 |
|
Does this mean we will soon have a pypi release? |
Closes #2041, follows on from #2088
This does not refactor the
IStanBackendclass or anything like that yet. It just removes pystan from the requirements.txt, and deletes the imports of it