Skip to content

Conversation

@WardBrian
Copy link
Collaborator

Closes #2041, follows on from #2088

This does not refactor the IStanBackend class or anything like that yet. It just removes pystan from the requirements.txt, and deletes the imports of it

@WardBrian
Copy link
Collaborator Author

After this is merged you the build_wheel can run and build for python 3.6-3.10. Until PyPi is updated that link will be the best bet

@jlopezpena
Copy link

This is great, I can confirm checking out this PR solves all the build issues on Mac with python 3.9+. It would be great to have this merged, and perhaps a new pypi packaged released, as the fact that the "official" pypi release doesn't work with any recent python is not great. IMO, the code refactoring can be postponed as it will not alter any functionality.

@WardBrian
Copy link
Collaborator Author

I think leaving the backend code for now could even be useful if things like #1973 get another look

@akosfurton
Copy link

This looks great!

Looking forward to this being merged and Prophet released to PyPi again

@WardBrian
Copy link
Collaborator Author

@tcuongd are you able to review this? I know there are some permissions issues blocking a PyPi release as well, but this is one of the final roadblocks as I understand

@khanetor
Copy link
Contributor

Thank you! I think Prophet really need this because pystan is really problematic to install.

@jlopezpena
Copy link

Any updates on this issue? We have had all our environments pulling prophet to this PR for a few weeks now and everything is working fine. It would be great if an "official" release could be made

@nicolaerosia
Copy link

@tcuongd kind ping :)

nicolaerosia pushed a commit to nicolaerosia/prophet that referenced this pull request May 3, 2022
@tcuongd tcuongd self-requested a review May 5, 2022 07:27
@tcuongd
Copy link
Collaborator

tcuongd commented May 5, 2022

Yep this LGTM, thanks heaps! I'll trigger a wheel.yml workflow after the merge to test the 3.9-3.10 wheels as well.

@tcuongd tcuongd merged commit df411c9 into facebook:main May 5, 2022
@tcuongd
Copy link
Collaborator

tcuongd commented May 5, 2022

Successfully built wheels without pystan: https://github.com/facebook/prophet/actions/runs/2275140778
Huge thanks to @WardBrian!

@ShantanuKumar
Copy link

Does this mean we will soon have a pypi release?

@WardBrian WardBrian deleted the remove-pystan branch May 5, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove pystan backend, move to cmdstanpy

8 participants