Remove metro-minify-uglify
#1013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `metro-minify-terser` has been Metro's default JS minifier since Metro [0.73.0](https://github.com/facebook/metro/releases/tag/v0.73.0) (facebook#871). However, we have continued to publish the deprecated `metro-minify-uglify` and included it in `metro`'s dependencies for a time for convenience. (Consequently, package managers have displayed a confusing warning for the use of the deprecated `uglify-es`, even when it isn't actually used.) This PR removes `metro-minify-uglify` from the main branch and from `metro`'s dependencies. If any critical patches are required in future, they may be published from the `0.76.x` branch. Users wishing to use `metro-minify-uglify` as of the latest version published may still do so by adding `metro-minify-uglify@^0.76.0` to their project's dependencies and configuring [`transformer.minifierPath`](https://facebook.github.io/metro/docs/configuration/#minifierpath): ``` minifierPath: require.resolve('metro-minify-uglify') ``` Changelog: ``` - **[Breaking]**: Remove `metro-minify-uglify` from `metro` dependencies. ``` Differential Revision: D47000809 fbshipit-source-id: 3720c00c02cfa02e9c5c36f842708d16a48bccb5
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47000809 |
|
This pull request has been merged in 7a8fcd5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
metro-minify-terserhas been Metro's default JS minifier since Metro 0.73.0 (#871). However, we have continued to publish the deprecatedmetro-minify-uglifyand included it inmetro's dependencies for a time for convenience.(Consequently, package managers have displayed a confusing warning for the use of the deprecated
uglify-es, even when it isn't actually used.)This PR removes
metro-minify-uglifyfrom the main branch and frommetro's dependencies. If any critical patches are required in future, they may be published from the0.76.xbranch.Users wishing to use
metro-minify-uglifyas of the latest version published may still do so by addingmetro-minify-uglify@^0.76.0to their project's dependencies and configuringtransformer.minifierPath:Changelog:
Differential Revision: D47000809