Skip to content

Commit 7a8fcd5

Browse files
robhoganfacebook-github-bot
authored andcommitted
Remove metro-minify-uglify (#1013)
Summary: Pull Request resolved: #1013 `metro-minify-terser` has been Metro's default JS minifier since Metro [0.73.0](https://github.com/facebook/metro/releases/tag/v0.73.0) (#871). However, we have continued to publish the deprecated `metro-minify-uglify` and included it in `metro`'s dependencies for a time for convenience. (Consequently, package managers have displayed a confusing warning for the use of the deprecated `uglify-es`, even when it isn't actually used.) This PR removes `metro-minify-uglify` from the main branch and from `metro`'s dependencies. If any critical patches are required in future, they may be published from the `0.76.x` branch. Users wishing to use `metro-minify-uglify` as of the latest version published may still do so by adding `metro-minify-uglify@^0.76.0` to their project's dependencies and configuring [`transformer.minifierPath`](https://facebook.github.io/metro/docs/configuration/#minifierpath): ``` minifierPath: require.resolve('metro-minify-uglify') ``` Changelog: ``` - **[Breaking]**: Remove `metro-minify-uglify` from `metro` dependencies. ``` Reviewed By: motiz88 Differential Revision: D47000809 fbshipit-source-id: aa3ab28ba6fc1cb35415247ef07aace952aa47f8
1 parent 260125e commit 7a8fcd5

File tree

7 files changed

+1
-227
lines changed

7 files changed

+1
-227
lines changed

packages/metro-minify-uglify/.npmignore

-6
This file was deleted.

packages/metro-minify-uglify/package.json

-21
This file was deleted.

packages/metro-minify-uglify/src/__tests__/minify-test.js

-100
This file was deleted.

packages/metro-minify-uglify/src/index.js

-16
This file was deleted.

packages/metro-minify-uglify/src/minifier.js

-69
This file was deleted.

packages/metro/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
"metro-file-map": "0.76.7",
4444
"metro-inspector-proxy": "0.76.7",
4545
"metro-minify-terser": "0.76.7",
46-
"metro-minify-uglify": "0.76.7",
4746
"metro-react-native-babel-preset": "0.76.7",
4847
"metro-resolver": "0.76.7",
4948
"metro-runtime": "0.76.7",

yarn.lock

+1-14
Original file line numberDiff line numberDiff line change
@@ -2152,11 +2152,6 @@ commander@^2.20.0:
21522152
resolved "https://registry.yarnpkg.com/commander/-/commander-2.20.3.tgz#fd485e84c03eb4881c20722ba48035e8531aeb33"
21532153
integrity sha512-GpVkmM8vF2vQUkj2LvZmD35JxeJOLCwJ9cUkugyk2nuhbv3+mJvpLYYt+0+USMxE+oj+ey/lJEnhZw75x/OMcQ==
21542154

2155-
commander@~2.13.0:
2156-
version "2.13.0"
2157-
resolved "https://registry.yarnpkg.com/commander/-/commander-2.13.0.tgz#6964bca67685df7c1f1430c584f07d7597885b9c"
2158-
integrity sha512-MVuS359B+YzaWqjCL/c+22gfryv+mCBPHAv3zyVI2GN8EY6IRP8VwtasXn8jyyhvvq84R4ImN1OKRtcbIasjYA==
2159-
21602155
commondir@^1.0.1:
21612156
version "1.0.1"
21622157
resolved "https://registry.yarnpkg.com/commondir/-/commondir-1.0.1.tgz#ddd800da0c66127393cca5950ea968a3aaf1253b"
@@ -5846,7 +5841,7 @@ source-map@^0.5.6:
58465841
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.5.7.tgz#8a039d2d1021d22d1ea14c80d8ea468ba2ef3fcc"
58475842
integrity sha1-igOdLRAh0i0eoUyA2OpGi6LvP8w=
58485843

5849-
source-map@^0.6.0, source-map@^0.6.1, source-map@~0.6.1:
5844+
source-map@^0.6.0, source-map@^0.6.1:
58505845
version "0.6.1"
58515846
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.6.1.tgz#74722af32e9614e9c287a8d0bbde48b5e2f1a263"
58525847
integrity sha512-UjgapumWlbMhkBgzT7Ykc5YXUT46F0iKu8SGXq0bcwP5dz/h0Plj6enJqjz1Zbq2l5WaqYnrVbwWOWMyF3F47g==
@@ -6275,14 +6270,6 @@ typescript@5.0.4:
62756270
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.0.4.tgz#b217fd20119bd61a94d4011274e0ab369058da3b"
62766271
integrity sha512-cW9T5W9xY37cc+jfEnaUvX91foxtHkza3Nw3wkoF4sSlKn0MONdkdEndig/qPBWXNkmplh3NzayQzCiHM4/hqw==
62776272

6278-
uglify-es@^3.1.9:
6279-
version "3.3.9"
6280-
resolved "https://registry.yarnpkg.com/uglify-es/-/uglify-es-3.3.9.tgz#0c1c4f0700bed8dbc124cdb304d2592ca203e677"
6281-
integrity sha512-r+MU0rfv4L/0eeW3xZrd16t4NZfK8Ld4SWVglYBb7ez5uXFWHuVRs6xCTrf1yirs9a4j4Y27nn7SRfO6v67XsQ==
6282-
dependencies:
6283-
commander "~2.13.0"
6284-
source-map "~0.6.1"
6285-
62866273
unbox-primitive@^1.0.1:
62876274
version "1.0.1"
62886275
resolved "https://registry.yarnpkg.com/unbox-primitive/-/unbox-primitive-1.0.1.tgz#085e215625ec3162574dc8859abee78a59b14471"

0 commit comments

Comments
 (0)