Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lexical-website] Chore: upgrade to Docusaurus v3.6 - Docusaurus Faster #6761

Merged
merged 13 commits into from
Nov 5, 2024
Merged

[lexical-website] Chore: upgrade to Docusaurus v3.6 - Docusaurus Faster #6761

merged 13 commits into from
Nov 5, 2024
+6,544 −2,985

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Oct 25, 2024

Description

Upgrade Docusaurus to v3.6 (upcoming, WIP)

Enable the Docusaurus Faster options.

The site now bundles in 7 seconds instead of 50 seconds.
(However the doc gen phase remains slow)

Test plan

??? local or preview?

Before

npm run build --prefix packages/lexical-website

After

npm run build --prefix packages/lexical-website

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 25, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:41am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 4:41am

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
lexical - cjs 29.94 KB (0%)
lexical - esm 29.78 KB (0%)
@lexical/rich-text - cjs 38.59 KB (0%)
@lexical/rich-text - esm 31.63 KB (0%)
@lexical/plain-text - cjs 37.22 KB (0%)
@lexical/plain-text - esm 28.94 KB (0%)
@lexical/react - cjs 40.32 KB (0%)
@lexical/react - esm 33.01 KB (0%)

slorber
slorber commented Oct 25, 2024
View reviewed changes
Copy link
Contributor Author

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let you know once it's safe to review/merge

For now, I mostly needed a v3 site to test the upcoming faster features. I don't have access to the facebook preset source code so the goal was to test what changes I should advise the preset devs to do to add proper support.

package.json Outdated Show resolved Hide resolved
packages/lexical-website/package.json Outdated Show resolved Hide resolved
patches/docusaurus-plugin-internaldocs-fb+1.18.5.patch Outdated
@@ -0,0 +1,31 @@
diff --git a/packages/lexical-website/node_modules/docusaurus-plugin-internaldocs-fb/index.js b/packages/lexical-website/node_modules/docusaurus-plugin-internaldocs-fb/index.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporay patch, until the fb preset adds support for Rspack in an upcoming release

@slorber slorber mentioned this pull request Oct 25, 2024
Open
@slorber slorber marked this pull request as ready for review November 4, 2024 12:35
@slorber
Copy link
Contributor Author

slorber commented Nov 4, 2024

Docusaurus v3.6 is out: https://docusaurus.io/blog/releases/3.6

I'll let @antonk52 or @jknoxville follow up on the internal FB preset support for Rspack.

@antonk52
Copy link

antonk52 commented Nov 4, 2024

@slorber I've just released docusaurus-plugin-internaldocs-fb@1.19.0 that should work with rspack. the patch should no longer be needed

@slorber slorber changed the title [lexical-website] Chore: upgrade to Docusaurus v3.6 - WIP [lexical-website] Chore: upgrade to Docusaurus v3.6 - Docusaurus Faster Nov 4, 2024
@slorber
Copy link
Contributor Author

slorber commented Nov 4, 2024

Great, it's working 👍

Just did the PR cleanup, ready to review!

This command works well locally but I can't access Vercel logs:

npm run build --prefix packages/lexical-website

etrepum
etrepum approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you

@etrepum etrepum added this pull request to the merge queue Nov 5, 2024
Merged via the queue into facebook:main with commit af344f3 Nov 5, 2024
39 of 40 checks passed
This was referenced Nov 5, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etrepum etrepum etrepum approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@Fetz Fetz Awaiting requested review from Fetz Fetz is a code owner

@ivailop7 ivailop7 Awaiting requested review from ivailop7 ivailop7 is a code owner

@Sahejkm Sahejkm Awaiting requested review from Sahejkm Sahejkm is a code owner

@potatowagon potatowagon Awaiting requested review from potatowagon potatowagon is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slorber @antonk52 @etrepum @facebook-github-bot