-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-website] Breaking change: Upgrading docusaurus-plugin-typedoc
#6779
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @inhwaS! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
size-limit report 📦
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
It seems that there is an issue building the website with this change. Unfortunately I don't have permissions to see what the Vercel build error is. |
The docusaurus plugin was updated in #6761 which may affect this (at least it appears to have a conflict in package.json) |
the error is
logs: https://docs.google.com/document/d/13Gt5iz17SGlUE3Pm9387P3eDxX5hWm9vdSg6HP-UEyo/edit?usp=sharing |
Description
This pull request addresses issue #6072 by updating the version of
docusaurus-plugin-typedoc
.I refered this change log. Since it includes relevant modules, additional updates are required in other modules as well.
Changes Made
docusaurus-plugin-typedoc
version changed from0.22.0
->1.0.5
typedoc
version changed from0.25.12
->0.26.10
typedoc-plugin-frontmatter
plugin is added indocusaurus.config.js
Test plan
Before
Documents under
./packages/lexical-website/docs/api
and./packages/lexical-website/docs/packages
are generated successfully.After
Delete
./packages/lexical-website/docs/api
and./packages/lexical-website/docs/packages
folders and rununder
lexical-website
folder to confirm the documents are successfully generated.Issue still need to be fixed
There’s an issue with updating below.
lexical/packages/lexical-website/sidebars.js
Lines 23 to 25 in e96ee55
When I
./packages/lexical-website/docs/api
./packages/lexical-website
foldernpm run build
the files are not automatically regenerated.
I documented this problem on the #6072 page, but I haven’t been able to resolve it since I’m unsure who is responsible for it.
I also reached out to the
typedoc-plugin-markdown
module repository for help with modifying the code here, but I’m not certain how to implement a fix.Any assistance with this would be greatly appreciated.