Node-aware Context Menu Items #5791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivailop7
requested review from
zurfyx,
fantactuka,
acywatson and
Fetz
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
acywatson
reviewed
Apr 1, 2024
| @@ -199,10 +203,32 @@ export default function ContextMenuPlugin(): JSX.Element { | |||
| [editor], | |||
| ); | |||
|
|
|||
| const onWillOpen = (event: MouseEvent) => { | |||
| let newOptions = defaultOptions; | |||
| editor.update(() => { | |||
There was a problem hiding this comment.
This should probably be a read that returns the node type, then call an update onClick
There was a problem hiding this comment.
$getNearestNodeFromDOMNode works only inside editor.update(), unsure on why this is the case.
acywatson
reviewed
Apr 1, 2024
| @@ -97,6 +99,9 @@ export function LexicalContextMenuPlugin<TOption extends MenuOption>({ | |||
| const handleContextMenu = useCallback( | |||
| (event: MouseEvent) => { | |||
| event.preventDefault(); | |||
| if (onWillOpen) { | |||
There was a problem hiding this comment.
Can we be strict with the check here, like for onOpen and onClose?
acywatson
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose a 'onWillOpen' method that passes the 'contextmenu' mouse event, so users can do their logic what items should end up in the context menu before it's rendered. Have added an example for 'Link node', that appends an item to 'Remove Link' when a link node is right-clicked. Also fixed wrong positioning of the context menu when the page is scrolled.