feat: only do bitcode for iphone #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@Huxpro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@grabbou has updated the pull request. You must reimport the pull request before landing. |
|
@grabbou has updated the pull request. You must reimport the pull request before landing. |
|
Done 👌 |
There was a problem hiding this comment.
@Huxpro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Huxpro
pushed a commit
that referenced
this pull request
Oct 8, 2020
Summary: Bitcode is not needed for `iphonesimulator` - this PR makes bitcode to be included with iOS only. Reduces the package size by ~1GB. Related to #368 Pull Request resolved: #376 Reviewed By: willholen Differential Revision: D24031684 Pulled By: Huxpro fbshipit-source-id: 342b0139d208cdea6c2af2983c894b758a7d7789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bitcode is not needed for
iphonesimulator- this PR makes bitcode to be included with iOS only. Reduces the package size by ~1GB.Related to #368