Skip to content

Commit

Permalink
feat: only do bitcode for iphone (#376)
Browse files Browse the repository at this point in the history
Summary:
Bitcode is not needed for `iphonesimulator` - this PR makes bitcode to be included with iOS only. Reduces the package size by ~1GB.

Related to #368

Pull Request resolved: #376

Reviewed By: willholen

Differential Revision: D24031684

Pulled By: Huxpro

fbshipit-source-id: 342b0139d208cdea6c2af2983c894b758a7d7789
  • Loading branch information
grabbou authored and facebook-github-bot committed Oct 5, 2020
1 parent 30d3f18 commit a5617a5
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions utils/build-apple-framework.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,15 @@ fi
# Utility function to configure an Apple framework
function configure_apple_framework {
local build_cli_tools enable_bitcode
if [[ $1 == iphoneos ]]; then
enable_bitcode="true"
else
enable_bitcode="false"
fi
if [[ $1 == macosx ]]; then
build_cli_tools="true"
enable_bitcode="false"
else
build_cli_tools="false"
enable_bitcode="true"
fi

local cmake_flags=" \
Expand Down

0 comments on commit a5617a5

Please sign in to comment.