Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS build failures #355

Closed
wants to merge 2 commits into from
Closed

Conversation

neildhar
Copy link
Contributor

@neildhar neildhar commented Sep 17, 2020

A change in Homebrew has made it complicated to directly install
older versions of CMake. Switch back to the latest for now.

In addition, XCode GM has been released so to continue doing
arm64 builds, we need to use the beta version. More details here.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 17, 2020
@neildhar neildhar changed the title Install latest CMake with Homebrew Fix macOS build failures Sep 17, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neildhar has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@neildhar merged this pull request in 2e63cf7.

Huxpro pushed a commit that referenced this pull request Oct 8, 2020
Summary:
A change in Homebrew has made it complicated to directly install
older versions of CMake. Switch back to the latest for now.

In addition, XCode GM has been released so to continue doing
arm64 builds, we need to use the beta version. More details [here](https://discuss.circleci.com/t/xcode-12-gm-released/37437).

Pull Request resolved: #355

Reviewed By: haozhun

Differential Revision: D23752850

Pulled By: neildhar

fbshipit-source-id: fde05d2135974175d23002a4bd4091c3166225b8
@neildhar neildhar deleted the brew-latest-cmake branch October 20, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants