Skip to content

Commit

Permalink
Fix macOS build failures (#355)
Browse files Browse the repository at this point in the history
Summary:
A change in Homebrew has made it complicated to directly install
older versions of CMake. Switch back to the latest for now.

In addition, XCode GM has been released so to continue doing
arm64 builds, we need to use the beta version. More details [here](https://discuss.circleci.com/t/xcode-12-gm-released/37437).

Pull Request resolved: #355

Reviewed By: haozhun

Differential Revision: D23752850

Pulled By: neildhar

fbshipit-source-id: fde05d2135974175d23002a4bd4091c3166225b8
  • Loading branch information
neildhar authored and facebook-github-bot committed Sep 17, 2020
1 parent a649b79 commit 2e63cf7
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ workflows:
# Default settings for Apple jobs (apple-runtime, test-apple-runtime)
apple_defaults: &apple_defaults
macos:
xcode: "12.0.0"
xcode: "12.0.0-beta"
working_directory: ~/hermes
environment:
- TERM: dumb
Expand Down Expand Up @@ -196,7 +196,7 @@ jobs:
macos:
macos:
xcode: "12.0.0"
xcode: "12.0.0-beta"
environment:
- HERMES_WS_DIR: /tmp/hermes
- TERM: dumb
Expand All @@ -207,9 +207,7 @@ jobs:
- checkout
- run:
name: Install dependencies
# Force homebrew to install cmake 3.7
command: |
brew install ninja https://raw.githubusercontent.com/Homebrew/homebrew-core/d25c628ff2510f68c89f4660fc93e86377ae61dc/Formula/cmake.rb
command: brew install ninja cmake
- run:
name: Set up workspace
command: |
Expand Down

0 comments on commit 2e63cf7

Please sign in to comment.