-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not support sdk<=19 #42
Comments
Did you confirm that it does not crash on sdk <=19...I made similar changes but yet it crashes.. |
@nes123 Have you tried with a newer SDK, and does it work? If you do need to continue using older SDKs, please submit a PR. Thanks! |
I released react native app to production and notice that users that have android phones with sdk<=19 experience crashes. You can see the crash report for sdk=19 at my original post. |
happen to me as well in emulator pixel with api 27 |
same issue with app in production and also reproduced in emulator.
|
I tested 98d927d in a JellyBean emulator and it appears to be working. It'll be part of the next release we're currently trying to get out. |
wait for latest version hermes to landed on react native facebook/hermes#42
@willholen Would it be possible to deploy the fix (0.1.1) on the hermesvm package so we can overwrite it in our own package.json file while we wait for a new react-native release? Currently 0.1.0 is the latest here: https://www.npmjs.com/package/hermesvm |
@thomasonweb npm package was renamed to hermes-engine (0.1.1 is released) |
"Hello World" app built by version 0.1.1 crashes on all devices, Will be any fix for that? |
@javadi69 can you please open a new issue for this report? Also, please include the stack trace and a few lines before it from logcat. Thanks! |
@mhorowitz It wasn't hermes issue. |
I uploaded to Google Play and they apparently run some automated tests on their device leading to many crashes like this:
They all happen on Android 6.0.1. Shouldn't this be supported as it is API version 23 ? |
@mhorowitz it is not the same since my hermes is deactivated. Created a new ticket under #78 |
@nes123 Hello! Are you sure that it doesnt work for sdk version <= 19? Because I am facing a crash after building the apk for sdk version 19. The app crashes on startup. |
Hi, I tested the "react init app" on my "Yotaphone 2" with android 4.4.3 and also crashes on startup (only crashes with Hermes) Some system specs:
The adb logcat: |
@zicrox Is that where the log ends? It doesn't seem to mention any problem or crash. |
@willholen you are right the "logcat" is huge but I find the "FATAL EXCEPTION" section at the end, tell me if you need more details.
|
Still the same problem..i dont see any change |
This made my project work: facebook/react-native#25646 (comment) |
We are running RN Error: Logcat:
|
RN 0.60.5 uses hermes 0.1.0: https://github.com/facebook/react-native/blob/v0.60.5/package.json#L96. The link in the previous comment may help, too. |
Look the "^", when run install the version 0.1.1 is picked. |
Can you confirm which version is being used? If you built against an earlier version of Hermes, it might not get automatically upgraded by npm/yarn. |
Yes, that is from my yarn.lock.
|
Have you been able to reproduce this problem on other OS versions, or on other devices? Or is it specific to this device/OS combo? Is it possible for us to download the app, or can you provide a repo with a repro? |
This error is reported by PlayStore on the Pre-launch Reports. Unfortunately I don't have a device on hand to simulate the problem. This is a new pure React Native app with some dependencies. {
"name": "my-app",
"version": "0.0.1",
"private": true,
"scripts": {
"start": "react-native start",
"test": "jest",
"lint": "eslint . --cache",
"postinstall": "npx jetify"
},
"dependencies": {
"@react-native-community/async-storage": "1.6.1",
"axios": "0.19.0",
"bluebird": "3.5.5",
"eventemitter3": "4.0.0",
"husky": "3.0.2",
"jwt-decode": "2.2.0",
"moment-timezone": "0.5.26",
"prop-types": "15.7.2",
"react": "16.8.6",
"react-native": "0.60.5",
"react-native-actionsheet": "2.4.2",
"react-native-calendars": "https://github.com/smarppy/react-native-calendars.git#f6bc1677e47759bbb096390ae30e81e296923fbc",
"react-native-device-info": "2.3.2",
"react-native-firebase": "5.5.6",
"react-native-gesture-handler": "1.3.0",
"react-native-keyboard-manager": "4.0.13-12",
"react-native-modal-datetime-picker": "7.5.0",
"react-native-paper": "2.16.0",
"react-native-permissions": "1.2.0",
"react-native-reanimated": "1.1.0",
"react-native-screens": "1.0.0-alpha.22",
"react-native-simple-dialogs": "1.2.0",
"react-native-sound": "0.11.0",
"react-native-splash-screen": "3.2.0",
"react-native-tab-view": "2.9.0",
"react-native-vector-icons": "https://github.com/smarppy/react-native-vector-icons.git#add-fabric-icons",
"react-navigation": "3.11.1",
"react-redux": "7.1.0",
"redux": "4.0.4",
"redux-actions": "2.6.5",
"redux-form": "8.2.5",
"redux-thunk": "2.3.0",
"vanilla-masker": "1.2.0"
},
"devDependencies": {
"@babel/core": "7.5.5",
"@babel/runtime": "7.5.5",
"@react-native-community/eslint-config": "0.0.5",
"babel-eslint": "10.0.2",
"babel-jest": "24.8.0",
"babel-plugin-transform-remove-console": "6.9.4",
"eslint": "6.1.0",
"eslint-config-airbnb": "17.1.1",
"eslint-config-react-native": "4.0.0",
"eslint-plugin-import": "2.18.2",
"eslint-plugin-jsx-a11y": "6.2.3",
"eslint-plugin-react": "7.14.3",
"eslint-plugin-react-native": "3.7.0",
"jest": "24.8.0",
"jetifier": "1.6.4",
"metro-react-native-babel-preset": "0.56.0",
"react-test-renderer": "16.8.6"
},
"jest": {
"preset": "react-native"
}
} |
There are a lot of dependencies in there which aren't in the basic |
@mhorowitz @douglasjunior Hermes changed its npm name. It isn't hermes-vm anymore, but hermes-engine .
When you do this, you will have both hermes-vm and hermes-engine modules in your node_modules folder (as RN 0.60.5 still mentions hermes-vm). However, after you change the paths in build.gradle to point to hermes-engine instead, the compiler will link to the corrected engine (hermes-vm, at that point, should just be dead code), and you should be sailing smoothly from then on. Cheers! |
@jsaraiva |
@jsaraiva THX SO MUCH MAN! This was it (I upgraded from 60.4 to 60.5 and ran into this) |
Summary: This change sets the minSdkVersion to 16. Make sure to re-crosscompile LLVM as well as hermes itself. Confirmed running in an emulator with JellyBean API Level 16. Reviewed By: dulinriley Differential Revision: D16473377 fbshipit-source-id: 99a1f10386599c187a964d47c2ab97cbf5cf21aa
has same issue on android 4 when hermes is disabled |
Summary: Planning to upgrade the native build steps a little, but need to be up-to-date on build dependencies first. Pull Request resolved: facebookincubator/fbjni#42 Reviewed By: fabiomassimo Differential Revision: D26512246 Pulled By: passy fbshipit-source-id: 1fb059018b6b4ab0deb3a7f23ab2d6b70a7eac46
Bumps [normalize-url](https://github.com/sindresorhus/normalize-url) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/sindresorhus/normalize-url/releases) - [Commits](https://github.com/sindresorhus/normalize-url/commits) --- updated-dependencies: - dependency-name: normalize-url dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fatal Exception: java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libhermes.so caused by: dlopen failed: cannot locate symbol "posix_fallocate" referenced by "libhermes.so"...
at com.facebook.soloader.SoLoader.doLoadLibraryBySoName(SoLoader.java)
at com.facebook.soloader.SoLoader.loadLibraryBySoName(SoLoader.java)
at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java)
at com.facebook.soloader.SoLoader.loadLibrary(SoLoader.java)
at com.facebook.hermes.reactexecutor.HermesExecutor.()
at com.facebook.hermes.reactexecutor.HermesExecutorFactory.create(HermesExecutorFactory.java)
at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java)
at java.lang.Thread.run + 841(Thread.java:841)
The text was updated successfully, but these errors were encountered: