[0.60.2] Build failing when enabling Hermes (enableHermes: true)

[bhaskarGyan]

Build is failing when I enable Hermes in android/app/build.gradle

Error:

React Native version:

System:
OS: macOS 10.14.5
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Memory: 71.63 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.15.1 - /usr/local/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 23, 24, 25, 26, 27, 28
Build Tools: 21.1.2, 23.0.1, 25.0.0, 25.0.1, 25.0.2, 26.0.2, 26.0.3, 27.0.3, 28.0.0, 28.0.2, 28.0.3, 29.0.0
System Images: android-23 | Intel x86 Atom, android-23 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-27 | Android TV Intel x86 Atom, android-27 | Intel x86 Atom, android-27 | Intel x86 Atom_64, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Intel x86 Atom, android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom_64
Android NDK: 20.0.5594570
IDEs:
Android Studio: 3.4 AI-183.6156.11.34.5522156
Xcode: 10.2/10E125 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.2 => 0.60.2
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-create-library: 3.1.2
react-native-git-upgrade: 0.2.7

Steps To Reproduce

1. Follow the steps mentioned in hermes
2. react-native run-android --variant release

Describe what you expected to happen:
Build to pass after enabling Hermes

Snack, code example, or link to a repository:

https://github.com/bhaskarGyan/react-native-memory-profile/tree/bug/rn-0.60.2_hermes

[clangen-nw]

This seems to be caused by the hard-coded path to the hermes binary, here: https://github.com/facebook/react-native/blob/0.60-stable/react.gradle#L19

My npm install ended up placing it in a different location in node_modules, so I did the following in my android/app/build.gradle:

project.ext.react = [
    ...
    hermesCommand: "../../node_modules/hermesvm/%OS-BIN%/hermes",
    ...
]

[ecreeth]

@bhaskarGyan this issue has been fixed in #25598

[burhanyilmaz]

I have the same error :/ @bhaskarGyan did you solve it?

[ecreeth]

cc @bhaskarGyan @burhanyilmaz to fix this issue use the 0.60.3 React Native version

[Karniej]

@ecreeth I actually just installed 0.60.3 and my build succeeded , but the app crashes on start

[burhanyilmaz]

@ecreeth Thanks I solved this via #25598
it is really fast :)

[ecreeth]

@Karniej The React Native Team, recommend making sure everything works before trying to switch to Hermes. If everything is fine with your application, but with Hermes your application is broken, please send a issue

[farshidshahmoradi1996]

I have same issue with 0.60.3 in --variant release
(in dev is ok )

• What went wrong:
  Execution failed for task ':app:bundleReleaseJsAndAssets'.

A problem occurred starting process 'command '....\node_modules\hermesvm\win64-bin\hermes''

[ecreeth]

@farshidshahmoradi1996 I'm not sure, but I think that before using the command, we must take a few steps before. Here

[farshidshahmoradi1996]

when I open hermes.exe from node_modules\hermesvm\win64-bin that take error :

OS :win 8.1 (x64)

that problem comes from my windows?
I have this problem only in release version

[bhaskarGyan]

@ecreeth, #25598 fix the build issue but now the App is crashing on Startup.
Raised new issue #25601

I can close this issue if build is working for @farshidshahmoradi1996

[farshidshahmoradi1996]

@bhaskarGyan build is not working in --variant release

[burhanyilmaz]

There is no problem production and development in my app. But not starting js server when running react-native run-android.
There is a solution that react-native start & react-native run-android. it is not good.
Hermes cause this problem? @ecreeth

[cpojer]

Fixed in 0.60.3.