Skip to content

Commit

Permalink
Increase default max stack size (#923) (#923)
Browse files Browse the repository at this point in the history
Summary:
Original Author: 4092035+mikeduminy@users.noreply.github.com
Original Git: 1b759f4

As discussed in #135, the default stack size doesn't work for all use cases. In particular, when very large and complex bundles are loaded in dev mode.

This PR bumps the default stack size from `64*1024` (512kB) to `128*1024` (1MB). As suggested by tmikov in this comment - #135 (comment).

Pull Request resolved: #923

Original Reviewed By: tmikov

Original Revision: D43630032

Reviewed By: tmikov

Differential Revision: D44770995

fbshipit-source-id: 400221033e4c1e079535342331c99561f141b830
  • Loading branch information
avp authored and facebook-github-bot committed Apr 7, 2023
1 parent b37ec20 commit b53d671
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion public/hermes/Public/RuntimeConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class PinnedHermesValue;
F(constexpr, PinnedHermesValue *, RegisterStack, nullptr) \
\
/* Register Stack Size */ \
F(constexpr, unsigned, MaxNumRegisters, 64 * 1024) \
F(constexpr, unsigned, MaxNumRegisters, 128 * 1024) \
\
/* Whether to allow eval and Function ctor */ \
F(constexpr, bool, EnableEval, true) \
Expand Down

0 comments on commit b53d671

Please sign in to comment.