Increase default max stack size #923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@neildhar has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
pushed a commit
that referenced
this pull request
Mar 7, 2023
Summary: As discussed in #135, the default stack size doesn't work for all use cases. In particular, when very large and complex bundles are loaded in dev mode. This PR bumps the default stack size from `64*1024` (512kB) to `128*1024` (1MB). As suggested by tmikov in this comment - #135 (comment). Pull Request resolved: #923 Reviewed By: tmikov Differential Revision: D43630032 Pulled By: neildhar fbshipit-source-id: 5f8cff91a5f01b6507870c61efa1ce507de67940
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
Summary: Original Author: 4092035+mikeduminy@users.noreply.github.com Original Git: 1b759f4 As discussed in #135, the default stack size doesn't work for all use cases. In particular, when very large and complex bundles are loaded in dev mode. This PR bumps the default stack size from `64*1024` (512kB) to `128*1024` (1MB). As suggested by tmikov in this comment - #135 (comment). Pull Request resolved: #923 Original Reviewed By: tmikov Original Revision: D43630032 Reviewed By: tmikov Differential Revision: D44770995 fbshipit-source-id: 400221033e4c1e079535342331c99561f141b830
lunaleaps
pushed a commit
to lunaleaps/hermes
that referenced
this pull request
Apr 12, 2023
Summary: As discussed in facebook#135, the default stack size doesn't work for all use cases. In particular, when very large and complex bundles are loaded in dev mode. This PR bumps the default stack size from `64*1024` (512kB) to `128*1024` (1MB). As suggested by tmikov in this comment - facebook#135 (comment). Pull Request resolved: facebook#923 Reviewed By: tmikov Differential Revision: D43630032 Pulled By: neildhar fbshipit-source-id: 5f8cff91a5f01b6507870c61efa1ce507de67940
lunaleaps
added a commit
that referenced
this pull request
Apr 13, 2023
Co-authored-by: Neil Dhar <neildhar@meta.com> Co-authored-by: Mike Duminy <4092035+mikeduminy@users.noreply.github.com> resolved: #923
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #135, the default stack size doesn't work for all use cases. In particular, when very large and complex bundles are loaded in dev mode.
This PR bumps the default stack size from
64*1024(512kB) to128*1024(1MB). As suggested by @tmikov in this comment - #135 (comment).