Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TravisCI build for Folly on MacOS #1109

Closed
wants to merge 1 commit into from
Closed

TravisCI build for Folly on MacOS #1109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
TravisCI build for Folly on MacOS 
Use homebrew bootstrap script for process;
  • Loading branch information
@calebmarchent
calebmarchent authored and Caleb Marchent committed Apr 12, 2019
commit 1231b7937a0e7625d83d3be10f11b0dfe14fc260
10 changes: 7 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,19 @@ matrix:
include:
- env: ['os_image=ubuntu:16.04', gcc_version=5]
services: [docker]
- os: osx

addons:
apt:
packages: python2.7

script:
# We don't want to write the script inline because of Travis kludginess --
# it looks like it escapes " and \ in scripts when using `matrix:`.
- ./build/fbcode_builder/travis_docker_build.sh
- if [[ "$TRAVIS_OS_NAME" == "osx" ]];
then
folly/build/bootstrap-osx-homebrew.sh;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should pass -DBUILD_TESTS=ON to this script so we build and run the tests. By default, the script does not build/run tests.

else
./build/fbcode_builder/travis_docker_build.sh;
fi

notifications:
webhooks: https://code.facebook.com/travis/webhook/