TravisCI build for Folly on MacOS #1109
Conversation
Use homebrew bootstrap script for process;
calebmarchent
force-pushed
the
travisci_for_macosx
branch
from
5959272 to
1231b79
Compare
| - ./build/fbcode_builder/travis_docker_build.sh | ||
| - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; | ||
| then | ||
| folly/build/bootstrap-osx-homebrew.sh; |
There was a problem hiding this comment.
I think we should pass -DBUILD_TESTS=ON to this script so we build and run the tests. By default, the script does not build/run tests.
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
We've dropped support for Travis in favor of Github Actions, which already has MacOS support. |
…r/getdeps/test (#1109) Summary: Pull Request resolved: facebookincubator/zstrong#1109 Reviewed By: ahornby, aleivag Differential Revision: D68009422 fbshipit-source-id: 1404341fe19ec0b001e93e4348590f0c4d1e0488
Use homebrew bootstrap script for process;
As Travis files are shared between many Facebook OSS projects; Folly .travis.yml needs to be forked to a unique file before this PR can be landed. This can only be done from within Facebook.