Remove red p_feasible halos from ArmEffectsPlot #4398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4398 +/- ##
=======================================
Coverage ? 96.20%
=======================================
Files ? 553
Lines ? 56717
Branches ? 0
=======================================
Hits ? 54564
Misses ? 2153
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpolson64
force-pushed
the
export-D83864978
branch
from
46f3329 to
56ef899
Compare
|
@mpolson64 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83864978. |
mpolson64
force-pushed
the
export-D83864978
branch
from
56ef899 to
46595c0
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 6, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Differential Revision: D83864978
mpolson64
force-pushed
the
export-D83864978
branch
from
46595c0 to
71a7e9b
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 6, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Differential Revision: D83864978
mpolson64
force-pushed
the
export-D83864978
branch
from
71a7e9b to
46595c0
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 7, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
mpolson64
force-pushed
the
export-D83864978
branch
from
46595c0 to
3a5b7cb
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 9, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 9, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 9, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 9, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 14, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
mpolson64
force-pushed
the
export-D83864978
branch
from
3a5b7cb to
57cfa69
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 14, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 14, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 14, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
Summary: As discussed in chat. This is currently not used, adds complexity, and should be broken out into its own "progression" plot in the future Reviewed By: lena-kashtelyan Differential Revision: D83863709
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 15, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
mpolson64
force-pushed
the
export-D83864978
branch
from
57cfa69 to
c79acfc
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 15, 2025
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot. Including it in ArmEffects increases visual density past a useful point, and add significant code complexity. Reviewed By: lena-kashtelyan Differential Revision: D83864978
|
This pull request has been merged in b57d277. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: p_feasible is very important to express to users and should be promoted to its own dedicated plot
Differential Revision: D83864978