Filter stale trials from Scatter, ArmEffects using built in filtering logic #4396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 6, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Differential Revision: D83869841
mpolson64
force-pushed
the
export-D83869841
branch
2 times, most recently
from
f9f2206 to
e321591
Compare
|
@mpolson64 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83869841. |
mpolson64
force-pushed
the
export-D83869841
branch
from
e321591 to
a5584c6
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 6, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 6, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Differential Revision: D83869841
mpolson64
force-pushed
the
export-D83869841
branch
from
a5584c6 to
1df322a
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 6, 2025
… logic (facebook#4396) Summary: Pull Request resolved: facebook#4396 Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Differential Revision: D83869841
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4396 +/- ##
=======================================
Coverage ? 96.20%
=======================================
Files ? 553
Lines ? 56755
Branches ? 0
=======================================
Hits ? 54602
Misses ? 2153
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 7, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 9, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 9, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
force-pushed
the
export-D83869841
branch
from
1df322a to
b8b1bd9
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 9, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 9, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 9, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 9, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 14, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 14, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
force-pushed
the
export-D83869841
branch
from
b8b1bd9 to
3b8a61f
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 14, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 14, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 14, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 14, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
force-pushed
the
export-D83869841
branch
from
3b8a61f to
53618e6
Compare
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 15, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 15, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 15, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Oct 15, 2025
… logic (facebook#4396) Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary. Reviewed By: lena-kashtelyan Differential Revision: D83869841
|
This pull request has been merged in 30eec3b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Was hardcoded with custom logic before, now we just use the attr on these two Analyses directly. This shaves down custom handling and allows us to override easily when necessary.
Differential Revision: D83869841