Implement colorscale in Arm Effects and Scatter (2/2) #4220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80104354 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4220 +/- ##
==========================================
- Coverage 96.12% 96.12% -0.01%
==========================================
Files 566 566
Lines 57445 57492 +47
==========================================
+ Hits 55220 55264 +44
- Misses 2225 2228 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shrutipatel31
force-pushed
the
export-D80104354
branch
from
2616834 to
07b5a87
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
Summary: This diff implements a colorscale in Ax's Arm Effects and Scatter plots if the number of trials (excluding candidate trials) exceeds 10. The changes include - 1. Using BOTORCH_COLOR_SCALE as the colorscale 2. Keeping count of the non-candidate and candidate trials that end up being plotted 3. Calculating if scale needs to be used based on the no. of non-candidate trials that end up in the plot 4. Updating scale/legend accordingly Differential Revision: D80104354
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80104354 |
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
Summary: Pull Request resolved: facebook#4220 This diff implements a colorscale in Ax's Arm Effects and Scatter plots if the number of trials (excluding candidate trials) exceeds 10. The changes include - 1. Using BOTORCH_COLOR_SCALE as the colorscale 2. Keeping count of the non-candidate and candidate trials that end up being plotted 3. Calculating if scale needs to be used based on the no. of non-candidate trials that end up in the plot 4. Updating scale/legend accordingly Differential Revision: D80104354
shrutipatel31
force-pushed
the
export-D80104354
branch
from
07b5a87 to
d2150b4
Compare
shrutipatel31
added a commit
to shrutipatel31/Ax
that referenced
this pull request
Aug 29, 2025
Summary: This diff implements a colorscale in Ax's Arm Effects and Scatter plots if the number of trials (excluding candidate trials) exceeds 10. The changes include - 1. Using BOTORCH_COLOR_SCALE as the colorscale 2. Keeping count of the non-candidate and candidate trials that end up being plotted 3. Calculating if scale needs to be used based on the no. of non-candidate trials that end up in the plot 4. Updating scale/legend accordingly Reviewed By: eonofrey Differential Revision: D80104354
shrutipatel31
force-pushed
the
export-D80104354
branch
from
d2150b4 to
83086cb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80104354 |
…(1/2) (facebook#4219) Summary: This diff modifies the legend for candidate trials in arm effects and scatter plot in Ax's analysis library. The changes include - 1. Adding a new function to plotly-utils to determine whether a given trial is a candidate trial 2. Unit tests for the new function 3. Adding a new legend label for candidate trials 4. Modifying the code in Arm Effects and Scatter plot to track what trials have been plotted and display the candidate legend accordingly. Reviewed By: eonofrey Differential Revision: D79855536
Summary: This diff implements a colorscale in Ax's Arm Effects and Scatter plots if the number of trials (excluding candidate trials) exceeds 10. The changes include - 1. Using BOTORCH_COLOR_SCALE as the colorscale 2. Keeping count of the non-candidate and candidate trials that end up being plotted 3. Calculating if scale needs to be used based on the no. of non-candidate trials that end up in the plot 4. Updating scale/legend accordingly Reviewed By: eonofrey Differential Revision: D80104354
shrutipatel31
force-pushed
the
export-D80104354
branch
from
83086cb to
c616cc4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D80104354 |
Contributor
|
This pull request has been merged in ad665c6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff implements a colorscale in Ax's Arm Effects and Scatter plots if the number of trials (excluding candidate trials) exceeds 10. The changes include -
Differential Revision: D80104354